Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize/update events, $.on(), wrappers for any block and more #27

Closed
wants to merge 7 commits into from

Conversation

dmythro
Copy link

@dmythro dmythro commented May 12, 2014

Also added $.fn.tinyscrollbarUpdate() method, for window resize events.
Thumb min size (very helpful for long lists). Improved selectors speed
and heights calculation.

Please check it out and if makes sense - standalone version update is required as well.

Also added $.fn.tinyscrollbarUpdate() method, for window resize events.
Thumb min size (very helpful for long lists). Improved selectors speed
and heights calculation.
@wieringen
Copy link
Owner

Thanks I will take a look :)

@wieringen
Copy link
Owner

I don't understand why you added a update method. There all ready is one. I guess that way is a little more convenient. What I dont like about its is that it exposes another method to the $.fn namespace.

@dmythro
Copy link
Author

dmythro commented May 22, 2014

Well, that's one-line update (e.g. when resized) with setting scrollTo position. Also, when no Scrollbar inited - get a new one with default settings.

It's useful with current project. But maybe you have better idea how it may be done nicely?

@ange007
Copy link

ange007 commented Jul 15, 2014

This commit will be accepted and updated?
Very good thing.

@dmythro
Copy link
Author

dmythro commented Jul 17, 2014

@wieringen I'll update for auto-merge if you want, because since it's waiting has conflicts now. But anyway I didn't update the standalone version.

Auto-wrap if needed is highly important for web apps to not duplicate markup for every control.

@asleepwalker
Copy link

Hmm, it seems like auto-wrap repeats again at every update().
After three updates my DOM looks like .viewport > .overflow > .viewport > .overflow > .viewport > .overflow > #content. It's really not good.

@asleepwalker
Copy link

Fixed it. asleepwalker/tinyscrollbar@b1ad9a1.

Fixed repeating auto-wrap on update()
@dmythro
Copy link
Author

dmythro commented Nov 12, 2014

Thanks!

@dmythro
Copy link
Author

dmythro commented Mar 5, 2019

@wieringen wow, just realized it's still open! :)

@dmythro dmythro closed this Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants