Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image embedding #44

Closed
ninfernix opened this issue Aug 3, 2020 · 4 comments
Closed

Image embedding #44

ninfernix opened this issue Aug 3, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@ninfernix
Copy link

ninfernix commented Aug 3, 2020

Avalonia - 0.10 Preview 2

There doesn't seem to be support for embedding an image/bitmap inside the svg.
Example svg that has an image embedded and a circle. Only the circle gets rendered.

<?xml version="1.0" standalone="no"?>
<!DOCTYPE svg PUBLIC "-//W3C//DTD SVG 1.1//EN"
        "http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd">
<svg height="68px" width="61px" version="1.1"
     xmlns="http://www.w3.org/2000/svg" xmlns:xlink= "http://www.w3.org/1999/xlink">
<circle cx = "50" cy = "50" r = "40" stroke = "black" stroke-width = "3" fill = "red" />
    <image xlink:href="data:image/gif;base64,R0lGODlhPQBEAPeoAJosM//AwO/AwHVYZ/z595kzAP/s7P+goOXMv8+fhw/v739/f+8PD98fH/8mJl+fn/9ZWb8/PzWlwv///6wWGbImAPgTEMImIN9gUFCEm/gDALULDN8PAD6atYdCTX9gUNKlj8wZAKUsAOzZz+UMAOsJAP/Z2ccMDA8PD/95eX5NWvsJCOVNQPtfX/8zM8+QePLl38MGBr8JCP+zs9myn/8GBqwpAP/GxgwJCPny78lzYLgjAJ8vAP9fX/+MjMUcAN8zM/9wcM8ZGcATEL+QePdZWf/29uc/P9cmJu9MTDImIN+/r7+/vz8/P8VNQGNugV8AAF9fX8swMNgTAFlDOICAgPNSUnNWSMQ5MBAQEJE3QPIGAM9AQMqGcG9vb6MhJsEdGM8vLx8fH98AANIWAMuQeL8fABkTEPPQ0OM5OSYdGFl5jo+Pj/+pqcsTE78wMFNGQLYmID4dGPvd3UBAQJmTkP+8vH9QUK+vr8ZWSHpzcJMmILdwcLOGcHRQUHxwcK9PT9DQ0O/v70w5MLypoG8wKOuwsP/g4P/Q0IcwKEswKMl8aJ9fX2xjdOtGRs/Pz+Dg4GImIP8gIH0sKEAwKKmTiKZ8aB/f39Wsl+LFt8dgUE9PT5x5aHBwcP+AgP+WltdgYMyZfyywz78AAAAAAAD///8AAP9mZv///wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAACH5BAEAAKgALAAAAAA9AEQAAAj/AFEJHEiwoMGDCBMqXMiwocAbBww4nEhxoYkUpzJGrMixogkfGUNqlNixJEIDB0SqHGmyJSojM1bKZOmyop0gM3Oe2liTISKMOoPy7GnwY9CjIYcSRYm0aVKSLmE6nfq05QycVLPuhDrxBlCtYJUqNAq2bNWEBj6ZXRuyxZyDRtqwnXvkhACDV+euTeJm1Ki7A73qNWtFiF+/gA95Gly2CJLDhwEHMOUAAuOpLYDEgBxZ4GRTlC1fDnpkM+fOqD6DDj1aZpITp0dtGCDhr+fVuCu3zlg49ijaokTZTo27uG7Gjn2P+hI8+PDPERoUB318bWbfAJ5sUNFcuGRTYUqV/3ogfXp1rWlMc6awJjiAAd2fm4ogXjz56aypOoIde4OE5u/F9x199dlXnnGiHZWEYbGpsAEA3QXYnHwEFliKAgswgJ8LPeiUXGwedCAKABACCN+EA1pYIIYaFlcDhytd51sGAJbo3onOpajiihlO92KHGaUXGwWjUBChjSPiWJuOO/LYIm4v1tXfE6J4gCSJEZ7YgRYUNrkji9P55sF/ogxw5ZkSqIDaZBV6aSGYq/lGZplndkckZ98xoICbTcIJGQAZcNmdmUc210hs35nCyJ58fgmIKX5RQGOZowxaZwYA+JaoKQwswGijBV4C6SiTUmpphMspJx9unX4KaimjDv9aaXOEBteBqmuuxgEHoLX6Kqx+yXqqBANsgCtit4FWQAEkrNbpq7HSOmtwag5w57GrmlJBASEU18ADjUYb3ADTinIttsgSB1oJFfA63bduimuqKB1keqwUhoCSK374wbujvOSu4QG6UvxBRydcpKsav++Ca6G8A6Pr1x2kVMyHwsVxUALDq/krnrhPSOzXG1lUTIoffqGR7Goi2MAxbv6O2kEG56I7CSlRsEFKFVyovDJoIRTg7sugNRDGqCJzJgcKE0ywc0ELm6KBCCJo8DIPFeCWNGcyqNFE06ToAfV0HBRgxsvLThHn1oddQMrXj5DyAQgjEHSAJMWZwS3HPxT/QMbabI/iBCliMLEJKX2EEkomBAUCxRi42VDADxyTYDVogV+wSChqmKxEKCDAYFDFj4OmwbY7bDGdBhtrnTQYOigeChUmc1K3QTnAUfEgGFgAWt88hKA6aCRIXhxnQ1yg3BCayK44EWdkUQcBByEQChFXfCB776aQsG0BIlQgQgE8qO26X1h8cEUep8ngRBnOy74E9QgRgEAC8SvOfQkh7FDBDmS43PmGoIiKUUEGkMEC/PJHgxw0xH74yx/3XnaYRJgMB8obxQW6kL9QYEJ0FIFgByfIL7/IQAlvQwEpnAC7DtLNJCKUoO/w45c44GwCXiAFB/OXAATQryUxdN4LfFiwgjCNYg+kYMIEFkCKDs6PKAIJouyGWMS1FSKJOMRB/BoIxYJIUXFUxNwoIkEKPAgCBZSQHQ1A2EWDfDEUVLyADj5AChSIQW6gu10bE/JG2VnCZGfo4R4d0sdQoBAHhPjhIB94v/wRoRKQWGRHgrhGSQJxCS+0pCZbEhAAOw==" x="0" y="0" height="68px" width="61px"/>
</svg>
@wieslawsoltes wieslawsoltes added the bug Something isn't working label Aug 3, 2020
@wieslawsoltes
Copy link
Owner

The new Svg.Picture abstraction does not support setting image width and height. If you undefine USE_PICTURE in csproj than it works as expected.

@wieslawsoltes
Copy link
Owner

The Width and Height properties are not set when loading image data.

public float Width { get; set; } // TODO:
public float Height { get; set; } // TODO:

@ninfernix
Copy link
Author

ninfernix commented Aug 4, 2020

It doesn't compile if I remove USE_PICTURE in Svg.Skia.Avalonia.csproj

SvgImage.cs(17,16): error CS0234: The type or namespace name 'Skia' does not exist in the namespace 'Avalonia' (are you missing an assembly reference?) [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(167,17): error CS0246: The type or namespace name 'SP' could not be found (are you missing a using directive or an assembly reference?) [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(168,17): error CS0246: The type or namespace name 'SPA' could not be found (are you missing a using directive or an assembly reference?) [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]

or Svg.Skia

SvgImage.cs(57,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(71,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(57,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(71,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(57,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(71,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(57,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(71,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(57,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]
SvgImage.cs(71,41): error CS0117: 'SKSvg' does not contain a definition for 'ToModel' [C:\Users\User\Desktop\test\Svg.Skia\src\Svg.Skia.Avalonia\Svg.Skia.Avalonia.csproj]

@wieslawsoltes
Copy link
Owner

This will be fixed in next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants