New enwiki feature: total length of paragraphs without references #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
==========================================
+ Coverage 35.43% 36.07% +0.63%
==========================================
Files 33 33
Lines 1013 1023 +10
==========================================
+ Hits 359 369 +10
Misses 654 654
Continue to review full report at Codecov.
|
Ladsgroup
requested changes
Jan 15, 2018
wikiclass/feature_lists/enwiki.py
Outdated
| @@ -60,6 +82,7 @@ | |||
| main_article_templates / max(wikitext.revision.content_chars, 1), | |||
| (english.stemmed.revision.stem_chars / | |||
| max(wikitext.revision.content_chars, 1)), | |||
| paragraphs_without_refs_total_length, | |||
There was a problem hiding this comment.
One thing, this without scaling can cause abnormalities in the result, you need to add "log" to counting features, look at https://github.com/wiki-ai/wikiclass/blob/9e7660d6a2054119662de887e79456f44d9adf98/wikiclass/feature_lists/wikibase.py for example
nikitavbv
force-pushed
the
master
branch
2 times, most recently
from
6c9aeaf
to
7d9a311
Compare
Ladsgroup
reviewed
Jan 15, 2018
|
|
||
| Short line.<ref>last</ref><ref>One more reference</ref> | ||
| """ | ||
| assert solve(enwiki.paragraphs_without_refs_total_length, |
Ladsgroup
approved these changes
Jan 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: T174384