Fix merge_label utility argument order #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it more understandable
Ladsgroup
commented
Feb 22, 2018
| @@ -34,7 +34,6 @@ models: \ | |||
| lvwiki_models \ | |||
| nlwiki_models \ | |||
| nowiki_models \ | |||
| nowiki_models \ | |||
There was a problem hiding this comment.
I don't know how it got there but it's redundant and the auto-generation removed it, same for other removals.
Codecov Report
@@ Coverage Diff @@
## master #133 +/- ##
=======================================
Coverage 14.08% 14.08%
=======================================
Files 56 56
Lines 987 987
=======================================
Hits 139 139
Misses 848 848Continue to review full report at Codecov.
|
halfak
reviewed
Feb 23, 2018
Makefile
Outdated
| @@ -550,7 +546,7 @@ datasets/enwiki.human_labeled_revisions.20k_2015.json: | |||
| https://labels.wmflabs.org/campaigns/enwiki/4/ > $@ | |||
|
|
|||
| datasets/enwiki.labeled_revisions.20k_2015.json: \ | |||
| datasets/enwiki.human_labeled_revisions.20k_2015.json | |||
| datasets/enwiki.human_labeled_revisions20k_2015.json | |||
halfak
reviewed
Feb 23, 2018
templates/Makefile.j2
Outdated
| datasets/{{ wiki.name }}.{{ sample }}.{{ sample_name }}.json{% if not loop.last %} \{% endif -%} | ||
| {% endfor %} | ||
| {%- if big_sample.human_labeled_revisions %} | ||
| datasets/{{ wiki.name }}.human_labeled_revisions{{ big_sample.human_labeled_revisions }}.json{%- if big_sample.autolabeled_revisions %} \ |
There was a problem hiding this comment.
I think you need to add the "." here
Ladsgroup
force-pushed
the
fix_merge_attempt_two
branch
from
6ae40b1
to
49b4ffa
Compare
|
Done, so stupid (facepalm) |
Ladsgroup
pushed a commit
that referenced
this pull request
Aug 20, 2018
Ladsgroup
pushed a commit
that referenced
this pull request
Dec 17, 2018
Ladsgroup
pushed a commit
that referenced
this pull request
Jan 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://phabricator.wikimedia.org/T187742