Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cawiki damaging and goodfaith models #138

Merged
merged 1 commit into from Mar 2, 2018
Merged

Add cawiki damaging and goodfaith models #138

merged 1 commit into from Mar 2, 2018

Conversation

Ladsgroup
Copy link
Member

Bug: T187732

@codecov
Copy link

codecov bot commented Mar 1, 2018 •
edited

Codecov Report

Merging #138 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #138   +/-   ##
=======================================
  Coverage   13.91%   13.91%           
=======================================
  Files          56       56           
  Lines         999      999           
=======================================
  Hits          139      139           
  Misses        860      860

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d738c22...43fd32a. Read the comment docs.

@halfak
Copy link
Member

halfak commented Mar 1, 2018

We should exclude the reverted model. Otherwise this looks good!

adamwight
adamwight approved these changes Mar 2, 2018
View reviewed changes
Copy link
Contributor

@adamwight adamwight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This patch does remove reverted models. Nice work!

@adamwight adamwight merged commit 1065425 into master Mar 2, 2018
@adamwight adamwight deleted the cawiki_campaign branch March 2, 2018 14:28
Ladsgroup added a commit that referenced this pull request Aug 20, 2018
@Ladsgroup @adamwight
Add cawiki damaging and goodfaith models (#138)
a3e83ee 
Bug: T187732
Ladsgroup added a commit that referenced this pull request Dec 17, 2018
@Ladsgroup @adamwight
Add cawiki damaging and goodfaith models (#138)
7662e18 
Bug: T187732
Ladsgroup added a commit that referenced this pull request Jan 21, 2019
@Ladsgroup @adamwight
Add cawiki damaging and goodfaith models (#138)
60360ed 
Bug: T187732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwight adamwight adamwight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ladsgroup @halfak @adamwight