Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust data model to references with somevalue-snaks #44

Closed
fer-rum opened this issue Mar 21, 2014 · 0 comments · Fixed by #53
Closed

Adjust data model to references with somevalue-snaks #44

fer-rum opened this issue Mar 21, 2014 · 0 comments · Fixed by #53
Labels
enhancement

Comments

@fer-rum
Copy link
Member

fer-rum commented Mar 21, 2014

The references in the dumpfiles might contain somevalue-snaks additional to value-snaks. The data model should reflect this possibility. The current state is that somevalue-snaks in referenced will be ignored.
mkroetzsch added a commit that referenced this issue Mar 31, 2014
@mkroetzsch
Introduced SnakGroups
a0d5e10 
The datamodel was updatd so that all lists of Snaks are grouped
by the snak property. This affects statement qualifiers and references.
Due to the latter, this also fixes issue #44.
@mkroetzsch mkroetzsch mentioned this issue Mar 31, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce SnakGroups into data model Wikidata/Wikidata-Toolkit
1 participant
@fer-rum