Warn if draft creator/submitter is blocked

[AntiCompositeNumber]

If the person who created a draft has been blocked, it would be useful for AFCH to warn reviewers like it does for a lack of {{reflist}} or a deleted page. Users might be blocked for sockpuppetry, spam, paid editing, or other reasons that would necessitate a closer review.

[codeswithroh]

@enterprisey Can I work in this issue ?

[Yash-g17]

Hey @enterprisey and @AntiCompositeNumber , I'd love to work on this issue
Can you please assign me ?

[vartikaSaxena]

Hey @enterprisey, if this issue is still open I would like to work on it.

[paul-111]

hey @enterprisey can i be assigned in this issue? i would love to work with it

[enterprisey]

@codeswithroh @Yash-g17 @vartikaSaxena sorry for the late reply. if you're still interested in working on this issue, please add a comment here saying that. If two or more people are interested, the one who posted the original comment earlier has precedence. Or if you want to work together I'd be happy with that too.
@abarsha if none of them respond in a day you can have it

[Yash-g17]

@enterprisey I'm still interested

[paul-111]

@Yash-g17 hey can we work together?

[Yash-g17]

@abarsha Yeah sure , but I'm not sure if this task requires two people , @enterprisey can you please guide us on this

[paul-111]

@Yash-g17 well even if this task needs one person other one can have experience and learn things which all we need. I guess it will beneficial for both of us

[enterprisey]

yeah, two people will be fine. there are many ways it can be split up. one way we can split it up is one person does the user interface (the message "this user is blocked", and it should also show the block reason), and the other person does the API call. If that sounds good let me know. there are other ways it can be split up, too. we can coordinate on Zulip if you both would like.

[enterprisey]

yeah. for this PR you will add a new function checkIsSubmitterBlocked() inside getSubmissionWarnings(), which is in src/modules.submissions.js.
@paul-111 you can start with figuring out which API call you would need to check if a particular user is blocked. for now you can start with the URL (i.e. https://en.wikipedia.org/w/api.php?some=stuff&goes=here). once you get that, try writing the JS to perform the API call and pull out the data we're interested in. examples are all throughout src/modules/submission.js, but try looking at the one at the top of checkDeletionLog().
@Yash-g17 read through the function getSubmissionWarnings and try to figure out how we would write that new function checkIsSubmitterBlocked, following the example of the other four functions already defined there (checkReferences, checkDeletionLog, checkReviewState, checkLongComments). assume you'll already have the data from the API, in particular, four strings: the reason for the block, when they were blocked (in the format "2014-10-08T03:21:32Z"), when the block expires (either "infinity" or a timestamp like for when they were blocked), and the other user who blocked them.

[paul-111]

@enterprisey hey is there any deadline?

[enterprisey]

Nope :)

[Yash-g17]

@enterprisey I'm done with my part

[enterprisey]

@Yash-g17 cool. Can you post your code in this discussion if it's not too long? paul-111 also finished their part and I've asked them to post it here as well. You all are making great progress.

[Yash-g17]

@enterprisey I'm sorry i was away for a while , anyways here's the code
function checkIsSubmitterBlocked() { currentTime = new Date().toJSON(); if (expireTime == "infinity" || expireTime > currentTime) { addWarning( "This User is Blocked by " + userWhoBlocked +"on :"+ blockTime + " Till :" + expireTime + ". Reason : " + reason, ); } }

[paul-111]

hey @Yash-g17 if i merge both of our code does this look okey?

function checkIfSubmitterIsBlocked(userName){

var deffered = $.Deffered();
AFCH.api.get( {
    'action': 'query',
    'list': 'user',
    'usprop': 'blockinfo',
    'ususers': userName
} ).then( function( data ) {

	currentTime = new Date().toJSON(); 

if (expireTime == "infinity" || expireTime > currentTime) {
 addWarning( "This User is Blocked by " + userWhoBlocked +"on :"+ blockTime + " Till :" + expireTime + ". Reason : " + reason, );
  } 

} ).catch( function ( error ) {
	 console.log('abort' + error );
   
} )

}```

[Yash-g17]

I think we should wait for @enterprisey for their opinion

[paul-111]

yup okey

[enterprisey]

Yes, that looks pretty good! Try testing the code. I have prepared https://test.wikipedia.org/wiki/Draft:AFCH_Issue_106, which is a draft created by a blocked user. If you put the checkIfSubmitterIsBlocked function above into the script, and also add checkIfSubmitterIsBlocked to the list in $.when at the end of getSubmissionWarnings, the new warning should show up. If it works, that's cool; if it doesn't work, try to see if you can figure out why.

[DawnArchi01]

hey ! I see no assignees to this project . I would love to contribute to the project . Since I'm quite new here , it would be really helpful if you can guide whenever necessary . @enterprisey