Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add colons to wikilinks that contain the word "draft" #257

Open
NovemLinguae opened this issue Feb 3, 2023 · 2 comments
Open

Don't add colons to wikilinks that contain the word "draft" #257

NovemLinguae opened this issue Feb 3, 2023 · 2 comments
Labels
C-bug Category: bug

Comments

@NovemLinguae
Copy link
Member

NovemLinguae commented Feb 3, 2023

Requested by InfiniteNexus at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation#Category_links

AFCH automatically adds colons to [[Category:abc]] type wikilinks so that drafts stay out of categories. So the above is converted to [[:Category:abc]]

This ticket is to code an exception for categories whose name contains the word "draft". According to InfiniteNexus, these are usually false positives.

Diff of incorrect AFCH behavior: https://en.wikipedia.org/w/index.php?diff=1137264750&diffmode=source

image

@NovemLinguae NovemLinguae added the C-bug Category: bug label Feb 3, 2023
@siddharthvp
Copy link
Member

Such adhoc exceptions can have false positives and aren't maintainable. The supported way to categorise drafts is via templates, so they don't get coloned, eg. via {{AfC topic}}, {{Draft article|subject=}}, etc.

@enterprisey
Copy link
Contributor

enterprisey commented Feb 12, 2023

That makes sense, but I think checking for Category:Draft articles subcategories would cover everything. And in fact PR #154 addresses precisely this (which leads us to #131, which this might be a dupe of, really) - we worked on it a bit ages ago and I'm sure the idea could be adapted into merge-ability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

3 participants