Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should escape non-nested vertical bars in comments #358

Closed
NovemLinguae opened this issue May 8, 2024 · 1 comment
Closed

should escape non-nested vertical bars in comments #358

NovemLinguae opened this issue May 8, 2024 · 1 comment
Labels
C-bug Category: bug

Comments

@NovemLinguae
Copy link
Member

NovemLinguae commented May 8, 2024

Requested by Squib at https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation#Signature_wikicode_problem%3F

Something like this should be checked by AFCH. If any vertical bars are found that aren't in nested templates, they should be changed to {{!}}, which is the proper escape character for these.

May also want to see if = instead of {{=}} causes the same bug.

May also want to add some unit tests for this. One equals non-nested, one equals nested, one vertical bar non-nested, one vertical bar nested.

Would probably need to run this escape function all over the place. AFCH places comments on the article itself for decline, reject, and comment operations, and also places comments on user talk pages for decline, reject, and comment operations.

@NovemLinguae NovemLinguae added the C-bug Category: bug label May 8, 2024
@primefac
Copy link

primefac commented May 8, 2024

See replies to that thread; reasonable concern has been raised that if we fix this issue (which is a known "do not do this" issue listed at WP:SIG) we're just covering up GIGO.

@NovemLinguae NovemLinguae closed this as not planned Won't fix, can't repro, duplicate, stale May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: bug
Projects
None yet
Development

No branches or pull requests

2 participants