Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WikiProjects banners are not correctly detected when inside of {{WikiProject banner shell}} #185

Open
zanhecht opened this issue Oct 28, 2021 · 3 comments

Comments

@zanhecht
Copy link
Contributor

zanhecht commented Oct 28, 2021

The script lists WikiProject banners on the talk page, but the script does not count WikiProject banners wrapped in {{WikiProject banner shell}}. This also causes redundant WikiProject Biography templates to be added if the "biography" box is checked.

I noticed a comment in the source that "We only want top level templates", but an exception should be made for {{WikiProject banner shell}}.

Screenshot of WikiProject detection and autofill on the accept screen:
image

@siddharthvp
Copy link
Member

Is there any script that does this correctly? I think there are some 4-6 scripts that add project banners to the talk page:
*AFCH
*AFC-submit-wizard.js
*AFC-add-project-tags.js
*Various draft sorter user scripts

It's good most of these scripts are now at least using the same data source. Ideally they could even use the same logic for adding/removing banners - because that's definitely involved.

@zanhecht
Copy link
Contributor Author

I have a draft sorter script that both detects and adds WikiProject banners within the banner shell, but its logic is a lot simpler that the AFCH script: https://en.wikipedia.org/wiki/User:Ahecht/Scripts/draft-sorter.js

@enterprisey
Copy link
Contributor

The AFCH script overcomplicates some things. It would be worth it to consider whether Ahecht's code can be adapted for use here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants