Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not mark as 'patrolled' when adding CSD tag #452

Closed
Insertcleverphrasehere opened this issue Nov 4, 2018 · 7 comments
Closed

Do not mark as 'patrolled' when adding CSD tag #452

Insertcleverphrasehere opened this issue Nov 4, 2018 · 7 comments

Comments

@Insertcleverphrasehere
Copy link

Per this discussion: https://en.wikipedia.org/wiki/Wikipedia_talk:New_pages_patrol/Reviewers#Should_we_stop_marking_articles_tagged_with_CSD_and_PROD_as_'reviewed'_now_that_we_can_filter_them_in_the_NewPagesFeed?
We are going to stop marking CSDs and PRODs as 'reviewed' in the new pages feed at New Page Patrol, to stop things falling through the cracks if the CSD tags are inappropriately removed or the PROD removal is missed.

Twinkle currently does not mark PRODs as 'patrolled' but does mark CSDs as 'patrolled'. We need this to change so that CSD's are no longer marked as 'patrolled'.

@Insertcleverphrasehere Insertcleverphrasehere changed the title Do not mark as 'patrolled when adding CSD tag Do not mark as 'patrolled' when adding CSD tag Nov 4, 2018
@Insertcleverphrasehere
Copy link
Author

To clarify, I know that this is toggle-able in the preferences pane, but this should be the default behaviour.

@Amorymeltzer
Copy link
Collaborator

@atlight Is this really as easy toggling L145 of twinkle.js? AFAICT, no pages exist with "markTaggedPagesAsPatrolled": true (which makes sense) so in theory, yeah?

@QEDK
Copy link
Contributor

QEDK commented Nov 5, 2018

@Amorymeltzer defaults aren't stored in user Twinkle prefs .js I think. It should be as simple as the change you suggested.

@QEDK
Copy link
Contributor

QEDK commented Nov 5, 2018

Currently, patrolling is enabled for CSD, XfD and tagging. The commit addresses CSD defaults per the RfC.

@QEDK
Copy link
Contributor

QEDK commented Nov 5, 2018

@MusikAnimal this can be closed.

@Amorymeltzer
Copy link
Collaborator

@QEDK In the future, if you write "Closes ####" or "Resolves ####" in your PR, it will happen automatically. See https://help.github.com/articles/closing-issues-using-keywords/

@QEDK
Copy link
Contributor

QEDK commented Nov 5, 2018

@QEDK In the future, if you write "Closes ####" or "Resolves ####" in your PR, it will happen automatically. See https://help.github.com/articles/closing-issues-using-keywords/

Righttt, I was under the idea only collaborators have that particular ability. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants