Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default cookie path should be "/", not "undefined" #68

Closed
ghost opened this issue Oct 25, 2011 · 1 comment
Closed

Default cookie path should be "/", not "undefined" #68

ghost opened this issue Oct 25, 2011 · 1 comment

Comments

@ghost
Copy link

ghost commented Oct 25, 2011

On
https://github.com/azatoth/twinkle/blob/2d5caddb7f70054457538fece23fcd9bb3aacdd7/morebits.js#L72
there is
cookie += "; path=" + path || "/";

I think this should be
cookie += "; path=" + (path || "/");
or else the result will be "path=undefined" instead of "path=/".

@atlight
Copy link
Collaborator

atlight commented Jan 16, 2012

Fixed, by removing the code :)

@atlight atlight closed this as completed Jan 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant