New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sample code for API: Options module #51
Conversation
Based on #55 |
@reefagirl Thanks for your contribution to this project! But, this is not related to any microtask that I've added to the task description on Phabricator T215682 :-/ I will try to create a microtask around the In the future, before starting work on a topic / sending a pull request, I would appreciate it if you discuss it with me on Zulip or Phabricator. That way I can verify if the particular contribution would be helpful or not for the project at the moment. |
My apologies, I will make sure to discuss topics before starting them in future. Thank you for your help, I greatly appreciate it. |
@reefagirl I don't know your Phabricator username, but I've added your Github username next to |
Thank you, I edited the Phabricator task description with my Phabricater username :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@reefagirl Overall your sample code looks great! Only thing I would add is that you can demonstrate in the same code how to change a few more settings maybe skin, nickname, etc.
I would like to merge this code sample when your documentation is ready to go live on MediaWiki too. I will also take another look at your code sample then. Make sure that you've actually tested it on test.wikipedia.org
.
Before submitting final changes, run it with Pylint (https://www.pylint.org) to eliminate any indentation errors.
Thank you. I will do the updates and commit them soon :) |
@srish thank you for your feedback. I made the commits to update the code. The documentation I created can be found at https://www.mediawiki.org/wiki/User:Areefat/Sandbox/API:Options Kindly let me know your feedback and any improvements to be made. Appreciate the opportunity to contribute! |
@reefagirl Thanks a lot for your work! Here is first round of feedback https://www.mediawiki.org/wiki/Topic:Uv9lt04gmcv10ggl :) |
@srish Thank you for taking your time to provide feedback. |
@reefagirl Mostly looking good :) You can remove all the translation markers as they are generated by the software... read more about it here: #74 (comment). When you are done, I will review your document one more time. |
@srish Thank you, |
Thanks a lot for your work on this! I've made some fixes to documentation here: You can copy paste the changes to MediaWiki.org. When you publish your changes make sure to say in the comment: "updated as per the improving the action API documentation project". For reference check following page's history as it recently got updated: https://www.mediawiki.org/w/index.php?title=API:Move&action=history. Let me know if you've any trouble while doing so :) |
Thank you @srish , very grateful to be a part of this project. |
I wrote sample code to change user options which is done via the Options module which can be viewed at https://www.mediawiki.org/wiki/API:Options.
As the code wasn't in the current repository or in the wiki page, I wrote a sample code for it.
I tested it by obtaining credentials via Special:BotPasswords, for a login token.