Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sample codes for API:Embeddedin #74

Merged
merged 2 commits into from Mar 6, 2019
Merged

Added sample codes for API:Embeddedin #74

merged 2 commits into from Mar 6, 2019

Conversation

didicodes
Copy link
Contributor

API:Embeddedin gets a list of all page(s) that embed (transclude) the given title.
My sample code displays all pages that embed the English Wikipedia's page on w:Computer.

  1. I have added the Get requests params to modules.json.
  2. The file is auto generated.
  3. I ran my codes through pylint and it passed all the Pylint tests.
  4. Added code and page description to README.md
    This is the link to the sandbox page I created for this API
    Kindly review @srish

@srish srish merged commit b238073 into wikimedia:master Mar 6, 2019
@srish
Copy link
Member

srish commented Mar 6, 2019

@edyasikpo thanks for your contribution! The page you worked on has been translated in many different languages. And, that is why it needs to be handled with care :)

I see that you've added translation markers like <!--T1--> and <!--T2--> to new sections. These tags are actually added by the translation software, and so we should not add them manually. I would encourage you to read this tutorial first: https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_example especially the section https://www.mediawiki.org/wiki/Help:Extension:Translate/Page_translation_example#Step_4:_Making_changes and make any necessary changes in your Sandbox. I will take another look then! Thanks!

@didicodes
Copy link
Contributor Author

@srish Thank you for your feedback. I will read through the tutorial and make the necessary changes soon.

@didicodes
Copy link
Contributor Author

Hello, @srish I have made the changes you requested for on API:Embeddedin
I removed all the translation makers and added only the <translate> </translate> tags. I posted it on Zulip some days ago but it seems posting it here on GitHub will make it easier for you to find and also review the changes. This is the link to my sandbox: https://www.mediawiki.org/wiki/User:Didicodes/Sandbox/API:Embeddedin
Please review!

@srish
Copy link
Member

srish commented Mar 13, 2019

@edyasikpo Thanks for making the changes :) It looks like you got it now how to deal with pages with translations ;-) It is ready to go in the main namespace now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants