-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compatibility to support Less.js 3.13.1 #55
Comments
Yeah, we should probably do this. I don't know how much work this would be, however. |
HI any plan for update compatible to less 4.1.1 ? I would like to see this package fully support php8 and also update to work with less 4 |
@mrtuvn I don't think our maintenance budget for Less.php will be able to accomodate the additional cost for developing that. However, I think I can make time to review/test/release pull requests that incrementally make the relevant improvements for Less 4 compat. |
i think you can open sponsors button for this repo. Just my opinions |
@mrtuvn Maintainers like myself are working part-time or full-time for Wikimedia Foundation. Additional funds would not help us in terms of priorisation. This is likely something we can't prioritise within the foundation scope unless Wikipedia needs it (e.g. MediaWiki core). However, while sponsoring us might not work, Less.js 3.x support is definitely on the roadmap. Pull requests are welcomed! I think we can help review/test/release pull requests that incrementally make the relevant improvements for Less 3.x and 4.x. |
Are there any specific PHP 8 issues you are aware of? Looks like the composer.json require for PHP has never explicitly prevented PHP 8, but obviously that doesn't mean it all works fine on PHP 8. I would imagine if you find any, they are more likely to be worked on as more standlone work. MediaWiki "supports" PHP 8 too, and therefore any other libraries that it uses needs to. |
Equivalent task on our own issue tracker: https://phabricator.wikimedia.org/T288498. This is now in progress! |
Closing in favour of specific tasks elsewhere in the issue tracker. The 5.0.0 release is out and has changed our target from 2.5 to 3.13, with various new features, and more to come. |
Should we need update less from 2.5.3 to more recently version ? Example 3.13.1
less.php/lib/Less/Version.php
Line 12 in a486d78
Current we stay at long time in 2.5.3 version
Should we have update to 3.9.0 or 3.13.1 ? Is there any timeline or eta for that ?
The text was updated successfully, but these errors were encountered: