Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compatibility to support Less.js 3.13.1 #55

Closed
mrtuvn opened this issue Jan 18, 2021 · 8 comments
Closed

Update compatibility to support Less.js 3.13.1 #55

mrtuvn opened this issue Jan 18, 2021 · 8 comments
Assignees
Labels
Type: Enhancement New feature or request

Comments

@mrtuvn
Copy link

mrtuvn commented Jan 18, 2021

Should we need update less from 2.5.3 to more recently version ? Example 3.13.1

public const less_version = '2.5.3'; // The less.js version that this build should be compatible with

Current we stay at long time in 2.5.3 version
Should we have update to 3.9.0 or 3.13.1 ? Is there any timeline or eta for that ?

@jdforrester jdforrester changed the title Update compatible less to more recently version Update compatibility with less.js to a more recent version Jan 19, 2021
@jdforrester
Copy link
Member

Yeah, we should probably do this. I don't know how much work this would be, however.

@jdforrester jdforrester added the Type: Enhancement New feature or request label Jan 19, 2021
@mrtuvn
Copy link
Author

mrtuvn commented Aug 4, 2021

HI any plan for update compatible to less 4.1.1 ? I would like to see this package fully support php8 and also update to work with less 4
Thanks and very appriciated all working at this project

@Krinkle
Copy link
Member

Krinkle commented Aug 9, 2021

@mrtuvn I don't think our maintenance budget for Less.php will be able to accomodate the additional cost for developing that. However, I think I can make time to review/test/release pull requests that incrementally make the relevant improvements for Less 4 compat.

@Krinkle Krinkle changed the title Update compatibility with less.js to a more recent version Update compatibility to support Less.js 3 and Less.js 4 Aug 9, 2021
@mrtuvn
Copy link
Author

mrtuvn commented Aug 9, 2021

i think you can open sponsors button for this repo. Just my opinions

@Krinkle
Copy link
Member

Krinkle commented Aug 10, 2021

@mrtuvn Maintainers like myself are working part-time or full-time for Wikimedia Foundation. Additional funds would not help us in terms of priorisation. This is likely something we can't prioritise within the foundation scope unless Wikipedia needs it (e.g. MediaWiki core).

However, while sponsoring us might not work, Less.js 3.x support is definitely on the roadmap. Pull requests are welcomed! I think we can help review/test/release pull requests that incrementally make the relevant improvements for Less 3.x and 4.x.

@reedy
Copy link
Member

reedy commented Aug 10, 2021

HI any plan for update compatible to less 4.1.1 ? I would like to see this package fully support php8 and also update to work with less 4

Are there any specific PHP 8 issues you are aware of? Looks like the composer.json require for PHP has never explicitly prevented PHP 8, but obviously that doesn't mean it all works fine on PHP 8.

I would imagine if you find any, they are more likely to be worked on as more standlone work. MediaWiki "supports" PHP 8 too, and therefore any other libraries that it uses needs to.

@Krinkle Krinkle changed the title Update compatibility to support Less.js 3 and Less.js 4 Update compatibility to support Less.js 3.13.1 Apr 29, 2024
@Krinkle
Copy link
Member

Krinkle commented Apr 29, 2024

Equivalent task on our own issue tracker: https://phabricator.wikimedia.org/T288498.

This is now in progress!

@Krinkle Krinkle self-assigned this Apr 29, 2024
@Krinkle
Copy link
Member

Krinkle commented Aug 6, 2024

Closing in favour of specific tasks elsewhere in the issue tracker. The 5.0.0 release is out and has changed our target from 2.5 to 3.13, with various new features, and more to come.

@Krinkle Krinkle closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Development

No branches or pull requests

4 participants