Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain other implementations under the same GitHub organisation #2

Closed
Krinkle opened this issue Nov 12, 2013 · 5 comments
Closed
Assignees

Comments

@Krinkle
Copy link
Member

Krinkle commented Nov 12, 2013

How would you feel about moving the PHP port (from MediaWiki) and original (now abandoned) implementation in Python (from Google) to this repository. We could implement (partially?) shared test cases and other things, and a nice common versioning and release notes scheme.

The nodejs implementation can continue to be published on npm. We could consider publishing the PHP implementation on Composer.

@trevorparscal
Copy link
Contributor

Let's do this thing!

/me awaits pull request

This was referenced Mar 14, 2014
@GaryJones
Copy link

How about moving all of them to a new organisation e.g. https://github.com/cssjanus ?

@Krinkle
Copy link
Member Author

Krinkle commented May 1, 2014

@GaryJones I like that (at least moving it to an organisation, including nicer github.io domain).

Separate repositories does make it harder to share data and enforce API parity. E.g. if we maintain the test cases centrally and fetch 'em in the unit tests, it could cause one of the implementations to have a broken build without it having changed anything. Whereas when in the same repo, we can require that interface changes update all implementations at once. But that also shows the obvious drawback (having to update all at once). Separate repositories certainly has more benefits than overhead I think. Thanks!

@Krinkle Krinkle added the task label Jul 4, 2014
@Krinkle Krinkle changed the title Maintain PHP and Python implementations in the same repo Maintain PHP and Python implementations under the same organisation Jul 4, 2014
@jdforrester
Copy link
Member

Seeing that the organisation exists, is this just waiting for the repos to be imported?

@Krinkle Krinkle self-assigned this Sep 7, 2014
@Krinkle Krinkle closed this as completed Oct 2, 2014
@Krinkle Krinkle changed the title Maintain PHP and Python implementations under the same organisation Maintain other implementations under the same GitHub organisation Oct 2, 2014
@Krinkle
Copy link
Member Author

Krinkle commented Oct 2, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants