-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for italic capital Greek letters #33
Add support for italic capital Greek letters #33
Conversation
There is currently no way to write a bold italic capital Greek letter (e.g. for angular velocity vector). The easiest way to achieve this in Math/MathJax is to use `\boldsymbol \varOmega` which is already supported by MathJax, but it is not recognized by texvc, so it is rejected. This commit adds all symbols for capital Greek variables (`varDelta`, `\varOmega`, ...) supported by MathJax (see https://docs.mathjax.org/en/latest/tex.html#v) to the list of supported macros.
Thank you for the pull request. However, there are two issues.
|
I think it would also be a good idea to have some visual tests before we deploy this. Currently, we have 92 visual test cases at Let me know if you run into trouble... documentation is really a problem. |
Submitted patch to add tests: https://gerrit.wikimedia.org/r/c/mediawiki/services/mathoid/+/514785 |
I did that via http://openmath.org/pipermail/wiki-l/2019-August/000000.html |
So… ? |
@d00rman how do we proceed here. Should I just release a new texvcjs version to npm? |
Added new test cases for Greek capital letters (\varDelta etc.) which should be added to texvcjs by the PR at wikimedia/mediawiki-services-texvcjs#33 Note that _all_ PNG files were rendered a bit differently on my machine (even though no visual difference was apparent). Not sure about the case (exact version of something somewhere?) and I am not including the changed PNG files, only the new ones. Which might mean these might be different on somebody _else's_ machine. Dunno, YMMV. Change-Id: I0e82a55ac799b45bff654d46cdba05f3142bb0f5
Yup, but there is no version bump in this PR. @mormegil-cz could you bump the version in package.json to 0.3.7 please? |
Version bumped. (Even though I’m not sure this is the best process – shouldn’t release management be separate to individual feature PRs? Not that it would matter much, of course.) |
@mormegil-cz this is now on npm however, the gerrit change needs to point to the latest texvcinfo version, which is 0.5.4. |
Added new test cases for Greek capital letters (\varDelta etc.) which should be added to texvcjs by the PR at wikimedia/mediawiki-services-texvcjs#33 Note that _all_ PNG files were rendered a bit differently on my machine (even though no visual difference was apparent). Not sure about the case (exact version of something somewhere?) and I am not including the changed PNG files, only the new ones. Which might mean these might be different on somebody _else's_ machine. Dunno, YMMV. Change-Id: I0e82a55ac799b45bff654d46cdba05f3142bb0f5
There is currently no way to write a bold italic capital Greek letter (e.g. for angular velocity vector).
The easiest way to achieve this in Math/MathJax is to use
\boldsymbol \varOmega
which is already supported by MathJax, but it is not recognized by texvc, so it is rejected.This commit adds all symbols for capital Greek variables (
varDelta
,\varOmega
, ...) supported by MathJax (see https://docs.mathjax.org/en/latest/tex.html#v) to the list of supported macros.