Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for italic capital Greek letters #33

Merged
merged 3 commits into from
Sep 24, 2019
Merged

Add support for italic capital Greek letters #33

merged 3 commits into from
Sep 24, 2019

Conversation

mormegil-cz
Copy link

There is currently no way to write a bold italic capital Greek letter (e.g. for angular velocity vector).

The easiest way to achieve this in Math/MathJax is to use \boldsymbol \varOmega which is already supported by MathJax, but it is not recognized by texvc, so it is rejected.

This commit adds all symbols for capital Greek variables (varDelta, \varOmega, ...) supported by MathJax (see https://docs.mathjax.org/en/latest/tex.html#v) to the list of supported macros.

There is currently no way to write a bold italic capital Greek letter (e.g. for angular velocity vector).

The easiest way to achieve this in Math/MathJax is to use `\boldsymbol \varOmega` which is already supported by MathJax, but it is not recognized by texvc, so it is rejected.

This commit adds all symbols for capital Greek variables (`varDelta`, `\varOmega`, ...) supported by MathJax (see https://docs.mathjax.org/en/latest/tex.html#v) to the list of supported macros.
@physikerwelt
Copy link
Member

Thank you for the pull request. However, there are two issues.

  1. We need test cases
  2. This is a change in syntax. Therefore it needs community support. You can ask this group https://phabricator.wikimedia.org/T195861 for feedback

@physikerwelt
Copy link
Member

I think it would also be a good idea to have some visual tests before we deploy this.

Currently, we have 92 visual test cases at
https://github.com/wikimedia/mathoid/blob/master/test/files/mathjax-texvc/test.md
these tests are automatically generated via
https://github.com/wikimedia/mathoid/blob/master/scripts/imgUpdate.js
to generate these test cases you'll have to overwrite the dependency to texvcjs here
https://github.com/wikimedia/mathoid/blob/master/package.json#L41

Let me know if you run into trouble... documentation is really a problem.

@mormegil-cz
Copy link
Author

Submitted patch to add tests: https://gerrit.wikimedia.org/r/c/mediawiki/services/mathoid/+/514785

@physikerwelt
Copy link
Member

2\. This is a change in syntax. Therefore it needs community support. You can ask this group https://phabricator.wikimedia.org/T195861 for feedback

I did that via http://openmath.org/pipermail/wiki-l/2019-August/000000.html

@mormegil-cz
Copy link
Author

Otherwise, I will merge the PR after August 26th, 2019

So… ?

@physikerwelt
Copy link
Member

@d00rman how do we proceed here. Should I just release a new texvcjs version to npm?

physikerwelt pushed a commit to physikerwelt/mathoid-server that referenced this pull request Sep 12, 2019
Added new test cases for Greek capital letters (\varDelta etc.) which should
be added to texvcjs by the PR at wikimedia/mediawiki-services-texvcjs#33

Note that _all_ PNG files were rendered a bit differently on my machine
(even though no visual difference was apparent). Not sure about the case
(exact version of something somewhere?) and I am not including the changed
PNG files, only the new ones. Which might mean these might be different
on somebody _else's_ machine. Dunno, YMMV.

Change-Id: I0e82a55ac799b45bff654d46cdba05f3142bb0f5
@d00rman
Copy link

d00rman commented Sep 16, 2019

@d00rman how do we proceed here. Should I just release a new texvcjs version to npm?

Yup, but there is no version bump in this PR. @mormegil-cz could you bump the version in package.json to 0.3.7 please?

@mormegil-cz
Copy link
Author

Version bumped. (Even though I’m not sure this is the best process – shouldn’t release management be separate to individual feature PRs? Not that it would matter much, of course.)

@physikerwelt physikerwelt merged commit fc8ff74 into wikimedia:master Sep 24, 2019
@physikerwelt
Copy link
Member

@mormegil-cz this is now on npm however, the gerrit change needs to point to the latest texvcinfo version, which is 0.5.4.

wmfgerrit pushed a commit to wikimedia/mediawiki-services-mathoid that referenced this pull request Nov 13, 2019
Added new test cases for Greek capital letters (\varDelta etc.) which should
be added to texvcjs by the PR at wikimedia/mediawiki-services-texvcjs#33

Note that _all_ PNG files were rendered a bit differently on my machine
(even though no visual difference was apparent). Not sure about the case
(exact version of something somewhere?) and I am not including the changed
PNG files, only the new ones. Which might mean these might be different
on somebody _else's_ machine. Dunno, YMMV.

Change-Id: I0e82a55ac799b45bff654d46cdba05f3142bb0f5
@mormegil-cz mormegil-cz deleted the greek-italic-capital branch December 5, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants