Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disk Address Packet #1

Open
Roxxik opened this issue Mar 11, 2016 · 1 comment
Open

Disk Address Packet #1

Roxxik opened this issue Mar 11, 2016 · 1 comment

Comments

@Roxxik
Copy link

Roxxik commented Mar 11, 2016

You could move the disk address packet onto the stack, to save some more bytes in the binary / allow a longer commandline. I saw that being done in the freebsd boot0 loader.

EDIT0: should save 16 Bytes, but needs two instructions to reserve and free stack space....
EDIT1: here's the link: https://github.com/freebsd/freebsd/blob/master/sys/boot/i386/boot0/boot0.S#L561
@wikkyk
Copy link
Owner

wikkyk commented Mar 31, 2016

Thanks. I was going to rewrite the loading code a bit to make it smaller anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wikkyk @Roxxik