refactor: fixed broke tests

wilburx9 · Mar 14, 2021 · 08c8459 · 08c8459
1 parent 4fe13dd
commit 08c8459
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 13 deletions.
diff --git a/lib/src/api/service/contracts/banks_service_contract.dart b/lib/src/api/service/contracts/banks_service_contract.dart
@@ -10,5 +10,5 @@ abstract class BankServiceContract {
   Future<TransactionApiResponse> validateToken(
       BankChargeRequestBody? requestBody, Map<String, String?> fields);
 
-  Future<List<Bank>?> fetchSupportedBanks();
+  Future<List<Bank>?>? fetchSupportedBanks();
 }
diff --git a/lib/src/widgets/checkout/bank_checkout.dart b/lib/src/widgets/checkout/bank_checkout.dart
@@ -38,7 +38,7 @@ class _BankCheckoutState extends BaseCheckoutMethodState<BankCheckout> {
   late AnimationController _controller;
   late Animation<double> _animation;
   var _autoValidate = AutovalidateMode.disabled;
-  Future<List<Bank>?>? _futureBanks;
+  late Future<List<Bank>?>? _futureBanks;
   Bank? _currentBank;
   BankAccount? _account;
   var _loading = false;

diff --git a/test/src/common/card_utils_test.dart b/test/src/common/card_utils_test.dart
@@ -58,10 +58,10 @@ void main() {
         Case(inp: 10, out: true),
         Case(inp: 100, out: true),
         Case(inp: 1000, out: true),
-        Case(inp: 20, out: false),
+        Case(inp: 23, out: false),
         Case(inp: 2000, out: true),
         Case(inp: 94, out: false),
-        Case(inp: 2020, out: false),
+        Case(inp: 2024, out: false),
         Case(inp: 87656776, out: false),
         Case(inp: 8, out: true),
         Case(inp: 0, out: true),

diff --git a/test/src/common/paystack_test.dart b/test/src/common/paystack_test.dart
@@ -5,7 +5,8 @@ import 'package:flutter_paystack/src/common/paystack.dart';
 import 'package:flutter_test/flutter_test.dart';
 
 void main() {
-  const MethodChannel channel = MethodChannel('plugins.wilburt/flutter_paystack');
+  const MethodChannel channel = MethodChannel(
+      'plugins.wilburt/flutter_paystack');
 
   TestWidgetsFlutterBinding.ensureInitialized();
 
@@ -22,7 +23,8 @@ void main() {
   group("$PaystackPlugin", () {
     test('is properly initialized with passed key', () async {
       var publicKey = Platform.environment["PAYSTACK_TEST_PUBLIC_KEY"] ?? "";
-      final plugin = await PaystackPlugin().initialize(publicKey: publicKey);
+      final plugin = PaystackPlugin();
+      await plugin.initialize(publicKey: publicKey);
       expect(publicKey, plugin.publicKey);
     });
   });

diff --git a/test/src/models/card_test.dart b/test/src/models/card_test.dart
@@ -205,7 +205,7 @@ void main() {
                 number: "6011000000000004",
                 cvc: "123",
                 expiryMonth: 09,
-                expiryYear: 20),
+                expiryYear: 23),
             out: true),
       ];
 

diff --git a/test/src/widgets/checkout/card_checkout_test.dart b/test/src/widgets/checkout/card_checkout_test.dart
@@ -14,13 +14,9 @@ import '../../common/widget_builder.dart';
 class MockedCardService extends Mock implements CardServiceContract {}
 
 void main() {
-  late String publicKey;
-
-  setUp(() {
-    publicKey = Platform.environment["PAYSTACK_TEST_PUBLIC_KEY"] ?? "";
-  });
-
   group("$CardCheckout", () {
+    String publicKey = Platform.environment["PAYSTACK_TEST_PUBLIC_KEY"] ?? "";
+
     final charge = Charge()
       ..amount = 20000
       ..currency = "USD"