Significant Re-Organisation and Modernisation for 5.0 Release #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves all existing integration tests into a Legacy namespace so they can be easily grouped and excluded as getting these tests to run is never likely to happen.
- Drop PHP versions prior to 7.4 - Setup initial dev dependencies - Declare json extension - Declare psr/http-client - Fix autoload configuration - Setup scripts - Add lockfile to git
…R-18 client with PSR-17 Factories
- Implement abstract class for re-use of Mock HTTP Client assertions - Add method to convert booleans to strings in query parameters - Report psalm stats in CI - Complete unit tests for Bounce related and stats related methods - Fix removal of 'empty' body and query parameters
- Change parameter type for $includeArchivedStreams in listMessageStreams to a boolean - Add tests for message stream related methods
Template models when given should be pretty much anything that can serialise to JSON, but object-like nonetheless.
…hat PHPUnit turns up the error level
gsteel
force-pushed
the
feature/modernise
branch
from
00cf055
to
7efa718
Compare
|
@pgraham3 - Is anyone at @ActiveCampaign able to review this? PHP 7.4 goes EOL in a week or two when 8.2 comes out. Given this PR passes on 8.2 RC, it might be a useful improvement to ensure compat with 8.2 |
|
@gsteel I reached out internally at AC about this PR and getting it merged. Will follow up when I hear back from the wider team on it. |
Closed
|
There really is no point having this patch hanging around. Shame it was such a waste of time. :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi There,
I use the Postmark PHP library in a lot of projects which I've recently migrated to PHP 8.1.
Because of the invalid PHP version constraint in
composer.json, this has introduced a lot of runtime errors that could have been avoided by limiting installation to tested versions of PHP.Not content with downgrading to an older version of PHP, I've updated this library significantly to suit my needs.
There are a number of BC breaks and reviewing this is going to be a fair bit of work, but I'll do my best to summarise the changes:
strict_typesenabledAdminClientmethods have been dropped\Postmark\Models\PostmarkExceptionhas been replaced with an interface\Postmark\Exception\PostmarkExceptionand there are a number of newly introduced types that implement this interfaceSorry this is such a large pull request, but due to how long other pull requests have been hanging around, I've got my own fork into a position where it can be released and used on >= 8.0 without runtime errors.