Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListEstablishmentComponent #38

Closed
maxdhn opened this issue Apr 28, 2019 · 1 comment
Closed

ListEstablishmentComponent #38

maxdhn opened this issue Apr 28, 2019 · 1 comment
Labels
enhancement New feature or request to do

Comments

@maxdhn
Copy link
Contributor

maxdhn commented Apr 28, 2019 •
edited
Loading

  • Supprimer public listEstablishment;
  • Renommer listEstablishment en establishments et typé correctement
  • Supprimer public categorie = this.service.result; et récupérer la catégorie a partir de la route (voir issue AppRoutingModule #32, CategorieComponent #34 )
  • Supprimer la méthode etaDetail non utilisé
  • Factoriser les deux <div class=".container"> en un, en utilisant une fonction .filter en TS ce qui permet de ne plus avoir besoin de estaDefault et estaCategorie
  • Utiliser CardComponent voir issue CardComponent (duplication de code) #50
@maxdhn maxdhn added enhancement New feature or request to do labels Apr 28, 2019
@maxdhn maxdhn mentioned this issue Apr 28, 2019
Closed
@MartialBlot
Copy link
Contributor

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request to do
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxdhn @MartialBlot