Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add backtrace to unknown errors messages #34

Merged
merged 1 commit into from Nov 12, 2018
Merged

Add backtrace to unknown errors messages #34

merged 1 commit into from Nov 12, 2018

Conversation

ojab
Copy link
Contributor

@ojab ojab commented Nov 8, 2018

Fixes #4

@coveralls
Copy link

coveralls commented Nov 8, 2018 •
edited

Pull Request Test Coverage Report for Build 174

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 99.054%
Totals Coverage Status
Change from base Build 170: 0.01%
Covered Lines: 419
Relevant Lines: 423
💛 - Coveralls

dsalahutdinov
dsalahutdinov reviewed Nov 9, 2018
View reviewed changes
Copy link
Collaborator

@dsalahutdinov dsalahutdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @ojab! Thank you for the pull request!

lib/logux/error_renderer.rb Outdated Show resolved Hide resolved
dsalahutdinov
dsalahutdinov approved these changes Nov 12, 2018
View reviewed changes
Copy link
Collaborator

@dsalahutdinov dsalahutdinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work!

lib/logux/error_renderer.rb Outdated Show resolved Hide resolved
@dsalahutdinov dsalahutdinov merged commit c33ca1f into logux:master Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsalahutdinov dsalahutdinov dsalahutdinov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ojab @coveralls @dsalahutdinov