This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
SWARM-992: Set a modifiable List to a field in var-args mutator method of List type model to enable the field to mutate #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d of List type model to enable the field to mutate Motivation ---------- The var-args mutator for some models whose type is List sets an unmodifiable List(jva.util.Arrays$ArrayList) to the field. If the field initializes as java.util.Arrays$ArrayList, we can't add elements to the field. Modifications ------------- Use java.util.stream.Collectors#toList() to get a modifiable List(java.util.ArrayList). Result ------ You can add elements to the initialized field.
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
add to whitelist |
gastaldi
approved these changes
Jan 11, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The var-args mutator for some models whose type is List sets
an unmodifiable List(jva.util.Arrays$ArrayList) to the field.
If the field initializes as
java.util.Arrays$ArrayList, we can't add elements to the field.
Modifications
Use java.util.stream.Collectors#toList() to get a modifiable List(java.util.ArrayList).
Result
You can add elements to the initialized field.