Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

Swarm 324: Bootstrap performance issues #10

Merged
merged 1 commit into from Mar 10, 2016
Merged

Swarm 324: Bootstrap performance issues #10

merged 1 commit into from Mar 10, 2016

Conversation

heiko-braun
Copy link
Contributor

This is for review purposes only.

Moving to persistent jandex indexes

@heiko-braun
Copy link
Contributor Author

@kenfinnigan Here's a working example for wfs-core. Maybe we can use it as a baseline for discussing the changes needed to enable persistent indexes?

@kenfinnigan
Copy link
Member

FYI, I had added the jandex plugin to parent pom so it can be shared across more than core.

Is there any benefit to customizing the index name? We're not doing anything WildFly Swarm specific in building the jandex right?

@heiko-braun
Copy link
Contributor Author

The custom index name is necessary, because otherwise it conflicts with indexes that WF expects at that location.

@kenfinnigan
Copy link
Member

Is it building differently than what WF expects? Otherwise I would not expect it to be an issue

@heiko-braun
Copy link
Contributor Author

yes, the indexes seem to be different. i didn't have the time to fully track down all the inner workings of deployer chains in WF and how they leverage jandex, but I can tell that our integration tests fail with indexes provided by us that carry the default name

@heiko-braun heiko-braun self-assigned this Mar 9, 2016
@heiko-braun heiko-braun changed the title Swarm 324: Bootstrap performance issues DON'T MERGE; Swarm 324: Bootstrap performance issues Mar 10, 2016
@heiko-braun heiko-braun changed the title DON'T MERGE; Swarm 324: Bootstrap performance issues DON'T MERGE -- Swarm 324: Bootstrap performance issues Mar 10, 2016
@heiko-braun
Copy link
Contributor Author

Cleaned up and squashed the commits to make it more comprehensible

@heiko-braun
Copy link
Contributor Author

With this build setup (jandex in the core pom) all our own fractions that don't reside within core inherit everything they need to make it work.

Only fractions that don't inherit from core would need to add the jandex plugin. But that's just the way it is. I don't think we do much about that.

@heiko-braun
Copy link
Contributor Author

With regard to the choices of

a) jandex in the fraction plugin and
b) jandex in it's own plugin (like it is now)

the first solution (a) sounds nice, but it would require adding the fraction plugin to any runtime module. currently it's only attached to the main module, but indexes generated at that level don't help.

the second option (b) seems to be most versatile, doesn't require additional changes to any downstream module and creates an index with every jar.

Long Story Short

It's complicated, don't ask any further, this is the best approach I could find to balance ease of use with imposed constraints.

@heiko-braun heiko-braun changed the title DON'T MERGE -- Swarm 324: Bootstrap performance issues Swarm 324: Bootstrap performance issues Mar 10, 2016
@heiko-braun
Copy link
Contributor Author

From my point of view this is ready to be merged

@bobmcwhirter
Copy link
Contributor

I'd say merge, and then I'll rebase my :spi stuff and get that in today, hopefully.

kenfinnigan added a commit that referenced this pull request Mar 10, 2016
Swarm 324: Bootstrap performance issues
@kenfinnigan kenfinnigan merged commit 385a722 into thorntail:master Mar 10, 2016
mkouba pushed a commit that referenced this pull request May 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants