Skip to content
This repository has been archived by the owner on Jun 7, 2021. It is now read-only.

SWARM-888: Gradle Plugin Hardcoded Modules resource directory #331

Merged
merged 1 commit into from Feb 8, 2017

Conversation

AdlerFleurant
Copy link
Contributor

Motivation

org.wildfly.swarm.plugin.gradle.SwarmExtension contains the below line:
this.moduleDirs.add(new File(this.project.getBuildDir(), "resources/main/modules"));

The output location is hardcoded. Gradle has the ability to modify the
resource output directory and this code will silently ignore modules
whenever the resource output directory is changed through Gradle.

Modifications

The hardcoded line was changed to utilize Gradle Main SourceSet output
directory. The solution still expects a "modules" directory under the output resource
directory.

Result

Changing Gradle resource output directory will no longer prevent the
loading of the modules.

  • Have you followed the guidelines in our Contributing document?
  • Have you created a JIRA and used it in the commit message?
  • Have you checked to ensure there aren't other open Pull Requests for the same issue?
  • Have you built the project locally prior to submission with mvn clean install?

Motivation
----------
org.wildfly.swarm.plugin.gradle.SwarmExtension contains the below line:
this.moduleDirs.add(new File(this.project.getBuildDir(), "resources/main/modules"));

The output location is hardcoded. Gradle has the ability to modify the
resource output directory and this code will silently ignore modules
whenever the resource output directory is changed through Gradle.

Modifications
-------------
The hardcoded line was changed to utilize Gradle Main SourceSet output
directory. The solution still expects a "modules" directory under the output resource
directory.

Result
------
Changing Gradle resource output directory will no longer prevent the
loading of the modules.
@thorntail-ci
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@thorntail-ci
Copy link
Contributor

Can one of the admins verify this patch?

@kenfinnigan
Copy link
Member

ok to test

@kenfinnigan kenfinnigan merged commit dd55ea6 into thorntail:master Feb 8, 2017
@AdlerFleurant AdlerFleurant deleted the SWARM-888 branch February 8, 2017 14:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
3 participants