This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
SWARM-888: Gradle Plugin Hardcoded Modules resource directory #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
org.wildfly.swarm.plugin.gradle.SwarmExtension contains the below line:
this.moduleDirs.add(new File(this.project.getBuildDir(), "resources/main/modules"));
The output location is hardcoded. Gradle has the ability to modify the
resource output directory and this code will silently ignore modules
whenever the resource output directory is changed through Gradle.
Modifications
The hardcoded line was changed to utilize Gradle Main SourceSet output
directory. The solution still expects a "modules" directory under the output resource
directory.
Result
Changing Gradle resource output directory will no longer prevent the
loading of the modules.
mvn clean install
?