New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-490] RBAC tests for authentication & authorization against LDAP #5166
Conversation
Build 834 is now running using a merge of e6e9f60bb3aa2f376bbaa30dab57d368c4921ed3 |
Build 834 outcome was SUCCESS using a merge of e6e9f60bb3aa2f376bbaa30dab57d368c4921ed3 |
Rebased on current master & added a test for |
Build 877 is now running using a merge of 7fdee700ee8aca28dda697797ca415263433f4f2 |
Build 877 outcome was SUCCESS using a merge of 7fdee700ee8aca28dda697797ca415263433f4f2 |
Rebased on current master & added tests for |
Build 950 outcome was FAILURE using a merge of 387ce24 Build problems:Failed tests detected
Failed tests
|
Those test failures are expected, see https://issues.jboss.org/browse/WFLY-2216. I guess that this PR will not be merged sooner than the fix, so I'll leave it open for now. If needed, I can close the PR and open another one later, once we have a fix. |
Merged. |
Please submit an EAP PR for these as well. Going forward let's treat RBAC like normal code; i.e. folks do their own backports. Thanks! |
Please keep using the WFLY-490 in the commit message though, as I'll use that when I audit that all commits got backported. :) |
Thanks Brian. I was waiting for this PR to be merged to WFLY before submitting an EAP PR, which I believe is the correct procedure anyway :-) |
You don't have to wait if you don't want to. I don't merge into EAP until the upstream PR is merged, but you can send it early if that's more convenient. The benefit of waiting is if there are changes made to the upstream PR you don't have to backport the change, so for a complicated one like this waiting certainly makes sense. |
No description provided.