[WFLY-1850] / [WFLY-1664] / [WFLY-2462] Enhancements to CLI configuration and address handling for resolving the 3 parts of a controllers address. #5435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build 1438 is now running using a merge of 303cf91c96bc458caa6819f73e8ee183d806b405 |
|
Build 1438 outcome was FAILURE using a merge of 303cf91c96bc458caa6819f73e8ee183d806b405 Build problems:Failed tests detected Failed tests |
|
Build 1446 is now running using a merge of e0fb4442581454f2425f66b2c5626a0e5f4bc46e |
|
Build 1446 outcome was SUCCESS using a merge of e0fb4442581454f2425f66b2c5626a0e5f4bc46e |
|
I'd like Alexey to look at this. It seems fine in terms of doing what you described. Once concern I have that Alexey can better evaluate is if there are any issues with incompatible changes to the embedded CLI API |
|
It does break the compatibility for the cli clients connecting to the controller (or creating the cli context) specifying the host and the port (not the default connect method w/o arguments) or those consulting the default host and port values. These methods are removed here. |
|
Ok I can add those methods back in, if there is nothing else I will get that done first thing tomorrow and update the pull request. |
…ctor exising address handling so that it is all handled in a single location instead of what we had reached with the logic duplicated over a number of locations.
… on the default controller, also add a legacy mapping that allows port 9999 to cause the protocol to be set to 'remoting'.
…in the CLI configuration.
…at the only top level element is the <jboss-cli /> element.
…is may be added by a URI conversion of an address with no protocol.
…PI in line with JBoss AS 7.2.0.Final - restored methods subsequently deprecated with references to new alternatives.
|
Build 1552 is now running using a merge of f08d12f |
|
Just pushed again after rebasing. The removed methods have been added back to bring them in-line with what was in in JBoss AS 7.2.0.Final i.e. not maintaining compatibility with methods only introduced during WildFly development. Secondly the added methods are marked as deprecated with links to the new methods. |
|
Thanks! |
|
Build 1552 outcome was SUCCESS using a merge of f08d12f |
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A dedicated attribute for the default protocol instead of using a part of the address of the default controller.
Legacy address handling mapping addresses with port 9999 to protocol remoting.
Protocol to port mappings for addresses with no port specified.
Alias definitions within the jboss-cli.xml configuration, allowing both overrides of addresses already in use and simplified aliases to remove the need to enter the full address.
Clean up of the associated schema to correctly reflect what can be used as a top level element in the configuration.