WFLY-2651 If there is a transaction active when the setup action first r...

[stuartwdouglas]

...uns don't attempt to close it

[wildfly-ci]

Build 2153 is now running using a merge of bafd08d

[wildfly-ci]

Build 2153 outcome was FAILURE using a merge of bafd08d
Summary: Tests failed: 1 (1 new), passed: 5530, ignored: 73 Build time: 1:29:58

Build problems:

Failed tests detected

java.lang.AssertionError: 0 invocations were routed to node-1
java.lang.AssertionError: 0 invocations were routed to node-1
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase.testStatelessFailover(RemoteFailoverTestCase.java:180)
    at org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase.testStatelessFailover(RemoteFailoverTestCase.java:101)

Failed tests

org.jboss.as.test.clustering.cluster.ejb.remote.RemoteFailoverTestCase(SYNC-tcp).testStatelessFailover: java.lang.AssertionError: 0 invocations were routed to node-1
    at org.junit.Assert.fail(Assert.java:88)
    at org.junit.Assert.assertTrue(Assert.java:41)

[bstansberry]

So you want to clean up if the tx exists when setup() was first called, but not if it's opened later? I believe that's what will happen here and it sounds different from what the comment at L103 says.

[stuartwdouglas]

oops.

I wonder why this seemed to fix the issue then. I will fix this up.

[wildfly-ci]

Build 2188 is now running using a merge of d7907b4

[wildfly-ci]

Build 2188 outcome was SUCCESS using a merge of d7907b4
Summary: Tests passed: 5531, ignored: 73 Build time: 1:27:27

[bstansberry]

Merged.

[velo]

Is this fix going to be present on any JBoss EAP release?

[ctomc]

@velo there was no bug reported for this in EAP, and as such it was not backported.
It looks like that it could be as well applied to EAP, but there should be bugzilla entered for it in https://bugzilla.redhat.com/ or a support case via http://access.redhat.com/

We don't automatically back port everything as fixes are not always applicable.