Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WFLY-3029] add remove-jndi operation for JMS resources #5963

Merged
merged 1 commit into from Mar 21, 2014

Conversation

jmesnil
Copy link
Member

@jmesnil jmesnil commented Feb 26, 2014

  • add remove-jndi operation to jms-queue, jms-topic and
    connection-factory resources
  • refactor the code to mutualize handlers for add-jndi and remove-jndi
    operations
  • add rollback handler for these operations

JIRA: https://issues.jboss.org/browse/WFLY-3029

@wildfly-ci
Copy link

Build 2792 is now running using a merge of 22ccc80

@jmesnil jmesnil closed this Feb 26, 2014
@jmesnil jmesnil reopened this Feb 26, 2014
@wildfly-ci
Copy link

Build 2796 is now running using a merge of 9becbb3

@wildfly-ci
Copy link

Build 2792 outcome was FAILURE using a merge of 9becbb3
Summary: Tests failed: 2 (2 new), passed: 5598, ignored: 78, muted: 1 Build time: 1:29:38

Build problems:

Failed tests detected

java.lang.AssertionError: Eastern European Time
java.lang.AssertionError: Eastern European Time
    at org.junit.Assert.fail(Assert.java:88)
    at org.jboss.as.ejb3.timer.schedule.CalendarBasedTimeoutTestCase.testWithStartInTheFutureAndLaterSchedule(CalendarBasedTimeoutTestCase.java:527)
    at org.jboss.as.ejb3.timer.schedule.CalendarBasedTimeoutTestCase.testCalendarBasedTimeout(CalendarBasedTimeoutTestCase.java:96)
java.lang.AssertionError:
java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.executeWithFailure(HornetQBackupActivationTestCase.java:520)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.checkConnectionFactory(HornetQBackupActivationTestCase.java:444)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupActivation(HornetQBackupActivationTestCase.java:128)
java.lang.AssertionError:
java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.executeWithFailure(HornetQBackupActivationTestCase.java:520)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.checkConnectionFactory(HornetQBackupActivationTestCase.java:444)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupFailoverAfterFailback(HornetQBackupActivationTestCase.java:195)

Failed tests

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupActivation: java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupFailoverAfterFailback: java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

@wildfly-ci
Copy link

Build 2796 outcome was FAILURE using a merge of 9becbb3
Summary: Tests failed: 2, passed: 5598, ignored: 78, muted: 1 Build time: 1:34:18

Build problems:

Failed tests detected

java.lang.AssertionError: Eastern European Time
java.lang.AssertionError: Eastern European Time
    at org.junit.Assert.fail(Assert.java:88)
    at org.jboss.as.ejb3.timer.schedule.CalendarBasedTimeoutTestCase.testWithStartInTheFutureAndLaterSchedule(CalendarBasedTimeoutTestCase.java:527)
    at org.jboss.as.ejb3.timer.schedule.CalendarBasedTimeoutTestCase.testCalendarBasedTimeout(CalendarBasedTimeoutTestCase.java:96)
java.lang.AssertionError:
java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.executeWithFailure(HornetQBackupActivationTestCase.java:520)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.checkConnectionFactory(HornetQBackupActivationTestCase.java:444)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupActivation(HornetQBackupActivationTestCase.java:128)
java.lang.AssertionError:
java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.executeWithFailure(HornetQBackupActivationTestCase.java:520)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.checkConnectionFactory(HornetQBackupActivationTestCase.java:444)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupFailoverAfterFailback(HornetQBackupActivationTestCase.java:195)

Failed tests

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupActivation: java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupFailoverAfterFailback: java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

@bstansberry
Copy link
Contributor

This would need a minor API version bump. Maybe a micro, but a minor seems safer in case by some off chance the WF 8.0.0 management version makes it into EAP.

@wildfly-ci
Copy link

Build 2802 is now running using a merge of 4e8cbb1

@wildfly-ci
Copy link

Build 2802 outcome was FAILURE using a merge of 4e8cbb1
Summary: Tests failed: 2, passed: 5603, ignored: 79 Build time: 1:29:39

Build problems:

Failed tests detected

java.lang.AssertionError:
java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.executeWithFailure(HornetQBackupActivationTestCase.java:520)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.checkConnectionFactory(HornetQBackupActivationTestCase.java:444)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupActivation(HornetQBackupActivationTestCase.java:128)
java.lang.AssertionError:
java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)
    at org.junit.Assert.assertFalse(Assert.java:64)
    at org.junit.Assert.assertFalse(Assert.java:74)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.executeWithFailure(HornetQBackupActivationTestCase.java:520)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.checkConnectionFactory(HornetQBackupActivationTestCase.java:444)
    at org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupFailoverAfterFailback(HornetQBackupActivationTestCase.java:195)

Failed tests

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupActivation: java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

org.jboss.as.test.manualmode.messaging.HornetQBackupActivationTestCase.testBackupFailoverAfterFailback: java.lang.AssertionError: null
    at org.junit.Assert.fail(Assert.java:86)
    at org.junit.Assert.assertTrue(Assert.java:41)

* add remove-jndi operation to jms-queue, jms-topic and
  connection-factory resources
* refactor the code to mutualize handlers for add-jndi and remove-jndi
  operations
* add rollback handler for these operations
* change jms-queue entries attribute to read-write. There is no
  reason this attribute can not be written (although the runtime
  will need to be reloaded to take it into account)
* bump up management version to 2.1.0

JIRA: https://issues.jboss.org/browse/WFLY-3029
@wildfly-ci
Copy link

Build 2803 is now running using a merge of 1663637

@wildfly-ci
Copy link

Build 2803 outcome was SUCCESS using a merge of 1663637
Summary: Tests passed: 5605, ignored: 79 Build time: 1:31:11

@jmesnil
Copy link
Member Author

jmesnil commented Feb 28, 2014

I've bumped up the messaging management version to 2.1.0 (minor increment) but I have not added any resource transformation for the new remove-jndi operation.

@bstansberry
Copy link
Contributor

I don't believe transformation is required. All it could do is provide a better error message than the one the legacy slave provides.

n1hility added a commit that referenced this pull request Mar 21, 2014
[WFLY-3029] add remove-jndi operation for JMS resources
@n1hility n1hility merged commit 7b27534 into wildfly:master Mar 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants