New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WFLY-3978] - PicketLink EAP 6.4 Issues #6884
Conversation
Linux Build 5356 is now running using a merge of 0e11f83 |
Linux Build 5356 outcome was SUCCESS using a merge of 2410722 |
Linux Build 5357 is now running using a merge of 2410722 |
Linux Build 5357 outcome was SUCCESS using a merge of 2410722 |
Linux Build 5358 is now running using a merge of 075f0a7 |
@@ -59,7 +59,7 @@ | |||
public static final KeyStoreProviderResourceDefinition INSTANCE = new KeyStoreProviderResourceDefinition(); | |||
|
|||
private KeyStoreProviderResourceDefinition() { | |||
super(ModelElement.KEY_STORE, ModelElement.KEY_STORE.getName(), KeyStoreProviderAddHandler.INSTANCE, KeyStoreProviderRemoveHandler.INSTANCE, FILE, RELATIVE_TO, PASSWORD, SIGN_KEY_ALIAS, SIGN_KEY_PASSWORD); | |||
super(ModelElement.KEY_STORE, KeyStoreProviderAddHandler.INSTANCE, KeyStoreProviderRemoveHandler.INSTANCE, FILE, RELATIVE_TO, PASSWORD, SIGN_KEY_ALIAS, SIGN_KEY_PASSWORD); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since there can be only one keystore, and it does not contain a name in the xml, I think hardcoding this as keystore=keystore is valid. Rather there is a problem with the query used in the BX, this is nothing particular to this use-case, rather something which we do in other places
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, Kabir. If users are not allowed to name providers as they wish, with their chosen name persisted, this change is not valid.
Linux Build 5358 outcome was FAILURE using a merge of 075f0a7 Build problems:Failed tests detected Failed tests
|
Linux Build 5365 is now running using a merge of c8f7a44 |
Linux Build 5365 outcome was SUCCESS using a merge of 61af6bf |
Linux Build 5366 is now running using a merge of 61af6bf |
Linux Build 5366 outcome was FAILURE using a merge of 61af6bf Build problems:Failed tests detected Failed tests
|
Linux Build 5367 is now running using a merge of d183d19 |
[WFLY-3978] - PicketLink EAP 6.4 Issues
Linux Build 5367 outcome was SUCCESS using a merge of d183d19 |
https://bugzilla.redhat.com/show_bug.cgi?id=1157710