WFLY-4916: Adds Red Hat Access Submodule for sending JDRs to Red Hat Access Insights #8246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 6, 2015 14:50
| <module name="org.jboss.as.controller"/> | ||
| <module name="org.jboss.as.server"/> | ||
| <module name="org.jboss.modules"/> | ||
| <module name="org.jboss.msc"/> |
There was a problem hiding this comment.
looking at deps of this jar https://github.com/redhataccess/redhat-support-lib-java/blob/master/pom.xml
it looks like you dont need
<module name="org.jboss.staxmapper"/>
<module name="org.jboss.as.controller"/>
<module name="org.jboss.as.server"/>
<module name="org.jboss.modules"/>
<module name="org.jboss.msc"/>
There was a problem hiding this comment.
removed these unused dependencies.
|
Also .class files do not belong to git. only sources. |
|
Fixed all noted issues. Please retest. |
|
Linux Build 8427 outcome was FAILURE using a merge of 5e11a62 Failed tests |
| <module name="javax.api"/> | ||
| <module name="javax.ws.rs.api" services="import"/> | ||
| <!-- <module name="javax.net.ssl" slot='main'/> --> | ||
| <module name="org.apache.commons.net" slot='main'/> |
There was a problem hiding this comment.
I mean that instead of dependancy here, you could just have
<artifact name="${commons-net:commons-net}"/>
as resource.
There was a problem hiding this comment.
I see what you're saying. I tried adding this to the module.xml of redhat-support-lib-java but I couldn't get it to build for some reason. I kept getting the following:
[WARNING] Rule 0: org.apache.maven.plugins.enforcer.BanTransitiveDependencies failed with message:
org.wildfly:wildfly-feature-pack:pom:10.0.0.CR3-SNAPSHOT
com.redhat.gss:redhat-support-lib-java:jar:2.0.11:compile has transitive dependencies:
commons-net:commons-net:jar:3.2:compile
There was a problem hiding this comment.
that is fine, enforcement works as it should :)
you need to add <exclude> for all transitive dependencies of the module
added 2 commits
October 8, 2015 22:11
|
Windows Build 3489 outcome was FAILURE using a merge of beed4ba Failed tests |
|
|
||
| @Override | ||
| protected boolean requiresRuntime(OperationContext context) { | ||
| return true; |
There was a problem hiding this comment.
This should not override the superclass. The superclass will ensure this only adds the service on server processes, not on the Host Controllers. JDR itself is only added on servers, so there is no benefit adding this service on the Host Controller. And, if we did want this for the Host Controller process, there is additional work needed. If you leave this always returning true, on a Host Controller if there are 2 profiles that include this subsystem, they will both try to add the service and that will fail due to a duplicate service.
There was a problem hiding this comment.
Removed override for requiresRuntime(...).
…quiresRuntime(...) override in InsightsSubsystemAdd; removed extraneous calls to start inside of InsightsService
|
Linux Build 8537 outcome was FAILURE using a merge of 3ce9687 |
|
Linux with security manager Build 3365 outcome was FAILURE using a merge of 3ce9687 |
|
Windows Build 3569 outcome was FAILURE using a merge of 3ce9687 |
| <parent> | ||
| <groupId>org.wildfly</groupId> | ||
| <artifactId>wildfly-parent</artifactId> | ||
| <version>10.0.0.CR3-SNAPSHOT</version> |
There was a problem hiding this comment.
10.0.0.CR3 has been released so this needs to be changed to 10.0.0.CR4-SNAPSHOT. I presume this is why this PR does not build.
|
Closing as we are not planning to move forward with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates submodule which sends the JDR on a daily basis. This schedule interval can be modified to send once a day, once every two days and so on. The submodule is not enabled by default, it must be added to the standalone.xml and then be called from the CLI with the following command:
./subsystem:insights:enable(rhn-uid=[redhat-uid],rhn-pw=[redhat-pw])
Once called, an initial JDR will be sent and then one will be sent daily.