WFLY-5319 fix org.jboss.as.test.integration.jpa.mockprovider.txtimeout.TxTimeoutTestCase #9981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t.TxTimeoutTestCase.test_negativeTxTimeoutVerifyReaperThreadCanceledTxTest failure, implement EntityManagerFactory.getProperties method to avoid NPE in JPA container. still fail due to https://gist.github.com/scottmarlow/1ae4a4abe98851b3fe6b1e602ba273d7
|
Good news is that we only see the below failure, bad news is that we now need a fix for [https://issues.jboss.org/browse/WFLY-8661] java.lang.AssertionError: entity manager should not of been closed by the reaper thread at org.junit.Assert.fail(Assert.java:88) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertFalse(Assert.java:64) at org.jboss.as.test.integration.jpa.mockprovider.txtimeout.TxTimeoutTestCase.test_negativeTxTimeoutTest(TxTimeoutTestCase.java:149) |
|
Closing so that the WF committers don't have to look at this (currently) broken pr :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.jboss.org/browse/JBEAP-10550 (not acked yet)
https://issues.jboss.org/browse/WFLY-5319
Address TxTimeoutTestCase.test_negativeTxTimeoutVerifyReaperThreadCanceledTxTest failure, by implementing EntityManagerFactory.getProperties method to avoid NPE in JPA container.
Still fails due to org.wildfly.transaction.client.AbstractTransaction.notifyAssociationListeners being called from Transaction Manager reaper thread (https://gist.github.com/scottmarlow/1ae4a4abe98851b3fe6b1e602ba273d7) which incorrectly tells the JPA container that the application has been disassociated from the active transaction. This is not the case, as the application thread, which is a different thread, is still associated with the (timed out) transaction.
The purpose of this pull request is make sure that we don't see any other unexpected failures on CI.