Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem in ShortestEdgeCollapse #88

Closed
jiangzhongshi opened this issue Jan 12, 2022 · 1 comment
Closed

Problem in ShortestEdgeCollapse #88

jiangzhongshi opened this issue Jan 12, 2022 · 1 comment
Assignees
@yunfanzhou
Labels
bug Something isn't working

Comments

@jiangzhongshi
Copy link
Collaborator

in ShortestEdgeCollapse.cpp:51-52

  • Do not use vid to query. Use tuple instead.
  • Get one ring edges return only the connected ones, that is not enough. All the previous ones from the tet are invalid now, and needs renewal.
@jiangzhongshi jiangzhongshi added the bug Something isn't working label Jan 12, 2022
@yunfanzhou
Copy link
Collaborator

yunfanzhou commented Jan 12, 2022 •
edited
Loading

Yes it is queried with the new tuple created during collapse. Line 51 wasn't used in query it is used to access the attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yunfanzhou yunfanzhou

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jiangzhongshi @yunfanzhou