Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing order dependency of test_remove_bookmark` #7

Merged
merged 1 commit into from Aug 14, 2021

Conversation

sturmianseq
Copy link
Contributor

This PR aims to improve test reliability by removing order dependency of test_remove_bookmark, by calling add_bookmark before executing remove_bookmark.

The test would fail if test_remove_bookmark is run ahead of test_add_bookmark, running commands pip install pytest-random-order; pytest --random-order tests/test_marlin.py:

>       mock_object.remove_bookmark()
tests/test_marlin.py:36: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <marlin.manage.ManageBookmark object at 0x7fa8a5f29580>

    def remove_bookmark(self):
        os.chdir(self.m_path)
>       os.unlink(self.bookmark_name)
E       FileNotFoundError: [Errno 2] No such file or directory: 'mock'

@wilfredinni wilfredinni merged commit 0bb1efa into wilfredinni:master Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants