Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi, can the code run probably? #1

Open
Corleone-Huang opened this issue Jul 19, 2021 · 7 comments
Open

Hi, can the code run probably? #1

Corleone-Huang opened this issue Jul 19, 2021 · 7 comments

Comments

@Corleone-Huang
Copy link

No description provided.

@kelsey-du
Copy link

I can run it, but it doesn't work,Did you solve it?

@Corleone-Huang
Copy link
Author

I can run it, but it doesn't work,Did you solve it?

No, it does not work for me either.

@wilile26811249
Copy link
Owner

wilile26811249 commented Jul 27, 2021

I also found this problem. I'm try to solve it .

@KyonP
Copy link

KyonP commented Oct 14, 2021

I am also looking forward to this code being updated.

I have tried several modifications, such as applying deeper MLPs with patch outputs and positional embedding, they didn't work.

outputs :

image
image

patches are the same. are there any suggestions? it would be very grateful.

@CodePothunter
Copy link

can't converge at all

@maysonma
Copy link

maysonma commented Jun 8, 2022

Hi, it seems there is a bug in the L2 Attention module.

The weights of the projection matrices for query and key in L2 Attention should be tied (same weights). Otherwise, the Lipschitzness cannot be guaranteed. This is missed in the code.

Hope it could help. :-)

@wgqa
Copy link

wgqa commented May 4, 2023

Hi, it seems there is a bug in the L2 Attention module.

The weights of the projection matrices for query and key in L2 Attention should be tied (same weights). Otherwise, the Lipschitzness cannot be guaranteed. This is missed in the code.

Hope it could help. :-)

Excuse me, big shots, did the code run successfully? How to run it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants