Windows release

[littleli]

• Feature request :)
• There are Linux and Mac OS artifacts
• Explore the ways to build Windows artifacts too

[littleli]

• it turned out to be entirely possible
• scripts don't work well on Windows

[wilkerlucio]

Maybe that can work, the reason I didn't had a windows build was because the Clojure support for Windows on Github Actions wasn't there, but I see DeLaGuardo/setup-clojure#1 and seems like its merged. I can try giving it another go 👍

[wilkerlucio]

I never built on Windows myself, do you have any comments about the process? Some hiccups you were able to overcome?

[littleli]

I recommend is to run everything from npm scripts instead of having shell (bash) scripts. It usually works everywhere including CI services and it unifies the build process.

I tried instructions from the readme but I had to slightly modify the steps on Windows:

npx shadow-cljs watch workspaces electron-background electron-renderer -A:dev:dev-ws:electron
cd shell\electron
npm i
npm run pack

It builds without any issues. I have Clojure on my Windows box installed using scoop installer.

Also some Clojurists use appveyor to build Clojure stuff for Windows. I do use appveyor for my scoop project, but to be honest I don't have enough knowledge about this. There is an example in electron-builder project.

[littleli]

Also I have a beef in this. If you're successful with the portable build I would like to add it to my scoop repository mentioned above.

[wilkerlucio]

Hello, I'm currently without a computer so its hard for me to try. Do you want to try it on your end? I think if you fork you can change the actions and run from your repo, if you can send a PR with the needed changes, I'll be glad to merge it in.

[wilkerlucio]

I just gave a try to that again today, but without success. This is where I got stuck: https://github.com/wilkerlucio/pathom-viz/runs/2397010521?check_suite_focus=true

The Clojure mode seems to support windows, but when I try to use it from Shadow there it fails.

[littleli]

hm, it seems to me that clojure is not available, right?

Can you try to put another step in the github action flow after clojure install step? Something like:

- name: Verify clojure installation
  run: clj --version

[wilkerlucio]

I'm not trying on this for the moment, but you can clone the repo and try yourself, if you figure it out I'll be happy to merge back.

To make a release there is the bb release-app task, which makes a tag with the current version from shells/electron/package.json and pushes it, which triggers the workflow.

[littleli]

Github action update PR: #37

[littleli]

also Windows release now available via Scoop installer: littleli/scoop-clojure#155

[wilkerlucio]

Closed by #37