true_min not found

[GuangchuangYu]

> library(gggenes)
>
> dummies <- make_alignment_dummies(
+   gggenes_example_genes,
+   aes(xmin = start, xmax = end, y = molecule, id = gene),
+   on = "genE"
+ )
Error in ifelse(side == "left", true_min, true_max) :
  object 'true_min' not found

This may due to the upgrade of dplyr.

> packageVersion("dplyr")
[1] ‘0.7.2’

[wilkox]

Thanks @GuangchuangYu, looks like it was a dplyr change. Should be working now.

[GuangchuangYu]

I also figure it out. I think it would be more safe to use select_ and all using column name (character).

I am think about using it with ggtree similar to https://stackoverflow.com/questions/45384281/ggjoy-facet-with-ggtree. It is not possible to work with facet_plot as you are using facet_wrap .

Maybe you can work out another version without facet_wrap, so that we can have lawremi/ggbio#83 using gggenes.

[GuangchuangYu]

FYI: a wrapper function geom_motif that works with ggtree.
YuLab-SMU/ggtree#148

[wilkox]

geom_motif looks like a good implementation of this idea. Since you're importing geom_gene_arrow, would it help if I tidy up 'gggenes' and put it on CRAN? Or you're welcome to just copy the functions straight into ggtree if you want.

BTW, thanks for making ggtree! It's a great package.

[GuangchuangYu]

thanks @wilkox for putting the gggenes on CRAN.

I think the geom_motif should be refined and better incorporated in gggenes.