Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with Crystal 0.7.2 #5

Closed
jhass opened this issue May 26, 2015 · 4 comments
Closed

Incompatible with Crystal 0.7.2 #5

jhass opened this issue May 26, 2015 · 4 comments

Comments

@jhass
Copy link
Contributor

jhass commented May 26, 2015

Error in ./libs/pg/pg/libpq.cr:9: empty structs are disallowed       

    struct PGconn   end                                              
    ^                                                                

@will
Copy link
Owner

will commented May 26, 2015

Thanks. I don't need to use anything in the structs (at least now), just as the thing to pass around to the other c functions. Do you know what I should use instead?

@will will closed this as completed in cafe1ea May 26, 2015
@jhass
Copy link
Contributor Author

jhass commented May 26, 2015

What you used looks fine to me, thanks! Where do you use atoi? It got removed because Crystals own to_is got improved.

@will
Copy link
Owner

will commented May 26, 2015

I have a C string from the driver, and I didn't want to copy it out of the result and into a crystal string just to turn it into an int: https://github.com/will/crystal-pg/blob/master/src/pg/decoder.cr#L60

@jhass
Copy link
Contributor Author

jhass commented May 26, 2015

Ah, I see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants