Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with Crystal 0.20.3 #74

Closed
jonahgeorge opened this issue Dec 24, 2016 · 1 comment
Closed

Issues with Crystal 0.20.3 #74

jonahgeorge opened this issue Dec 24, 2016 · 1 comment

Comments

@jonahgeorge
Copy link

in lib/db/src/db/database.cr:50: instantiating 'DB::Driver+#build_connection(DB::Database)'

        conn = @driver.build_connection(self).as(Connection)
                       ^~~~~~~~~~~~~~~~

in lib/pg/src/pg/driver.cr:3: instantiating 'PG::Connection:Class#new(DB::Database)'

    Connection.new(db)
               ^~~

instance variable '@connection' of PG::Connection must be PQ::Connection, not Nil

Error: instance variable '@connection' is initialized inside a begin-rescue, so it can potentially be left uninitialized if an exception is raised and rescued
@will
Copy link
Owner

will commented Dec 26, 2016

This should be fixed in v0.13.1 thanks to #75

@will will closed this as completed Dec 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants