Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: why fxhash ? #1

Closed
thomvil opened this issue Oct 21, 2023 · 1 comment
Closed

Question: why fxhash ? #1

thomvil opened this issue Oct 21, 2023 · 1 comment

Comments

@thomvil
Copy link

thomvil commented Oct 21, 2023

I found this crate by reading your blogpost Kudos, i much enjoyed it!

I noticed you depend on fxhash. I thought was designed for highly specific use-cases, and is vulnerable to collisions in many others? Did you choose fxhash specifically over alternatives as ahash?

If you could find the time, would you consider explaining a little about this choice?

Thanks in advance
@willcrichton
Copy link
Owner

Fxhash was just a fast hasher I knew off the top of my head. I'll have to check out ahash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thomvil @willcrichton