Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace String with Data.Text #20

Closed
k0ral opened this issue Aug 26, 2014 · 3 comments
Closed

Replace String with Data.Text #20

k0ral opened this issue Aug 26, 2014 · 3 comments

Comments

@k0ral
Copy link

k0ral commented Aug 26, 2014

Could you please adapt the API to accept Text objects in place of String ones ?
Thank you.
@noughtmare
Copy link
Contributor

noughtmare commented Jun 28, 2016 •
edited

Text is unnecessary in this package. The performance and memory usage improvement would be unnoticeable. This should wait until Data.Text is in base and the String/ByteString/Text problem is solved.

@k0ral
Copy link
Author

k0ral commented Jun 29, 2016

Fair enough.
Just for the sake of clarification, it's not about performance/memory gains, it's about not punishing Data.Text users with extra boilerplate to convert String <=> Text.
Anyway, feel free to close this issue if it's not going to be handled any time soon.

@frasertweedale
Copy link
Collaborator

Most of the strings are just for command line arguments and similar. I agree there is no benefit to changing to Text. Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@k0ral @frasertweedale @noughtmare