Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineProgram::lines_at_offset is pretty slow #61

Closed
calixteman opened this issue Sep 19, 2019 · 2 comments · Fixed by #68
Closed

LineProgram::lines_at_offset is pretty slow #61

calixteman opened this issue Sep 19, 2019 · 2 comments · Fixed by #68

Comments

@calixteman
Copy link
Contributor

Looking at https://github.com/willglynn/pdb/blob/master/src/modi/c13.rs#L897 it seems that getting all the line info for all the files is quadratic in the number of files.

@jan-auer
Copy link
Member

Correct. It currently parses all sections over and over again, instead of just once when constructing the line program.

I have a preliminaty fix for this already, will try to check it in soon.

@calixteman
Copy link
Contributor Author

It'd be nice :)
Using perf I noticed that 20% of the time is spent in this fonction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants