Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ssh path, ".ssh" missing in mount option #14

Closed
bartdorlandt opened this issue Oct 29, 2019 · 5 comments
Closed

ssh path, ".ssh" missing in mount option #14

bartdorlandt opened this issue Oct 29, 2019 · 5 comments

Comments

@bartdorlandt
Copy link
Contributor

in the mount and inject command example the .ssh portion is missing (on the right side of the ":").

@willhallonline
Copy link
Owner

Hey @bartdorlandt. I am not sure as this matters? Basically speaking there is only the root user inside the container, so it will make that if it doesn't already exist? I could make a .ssh directory? Would that resolve the issue?

@bartdorlandt
Copy link
Contributor Author

Hi @willhallonline , I was just referring to the documentation. I see now, that I wasn't very clear. apologies.

The documentation shows:
Mount local directory and ssh key
$ docker run --rm -it -v $(pwd):/ansible -v ~/.ssh/id_rsa:/root/id_rsa willhallonline/ansible:2.7 /bin/sh
Injecting commands
$ docker run --rm -it -v $(pwd):/ansible -v ~/.ssh/id_rsa:/root/id_rsa willhallonline/ansible:2.7 ansible-playbook playbook.yml

I believe they should be:
Mount local directory and ssh key
$ docker run --rm -it -v $(pwd):/ansible -v ~/.ssh/id_rsa:/root/.ssh/id_rsa willhallonline/ansible:2.7 /bin/sh
Injecting commands
$ docker run --rm -it -v $(pwd):/ansible -v ~/.ssh/id_rsa:/root/.ssh/id_rsa willhallonline/ansible:2.7 ansible-playbook playbook.yml

Note the ".ssh/" between root and id_rsa.

The bash_aliases show pretty much the same, but with the correct mount points.

if desired i could do a pull request.

@willhallonline
Copy link
Owner

If you want to do a PR that would be good 🥇 . If you don't want to then I'll do it, but I would love to say that someone else has contributed 👍 😀

@willhallonline
Copy link
Owner

You are totally right by the way with regards to the issue.

@bartdorlandt
Copy link
Contributor Author

PR done. cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants