Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the docformatter pre-commit action #16257

Open
carmocca opened this issue Jan 4, 2023 · 1 comment
Open

Update the docformatter pre-commit action #16257

carmocca opened this issue Jan 4, 2023 · 1 comment
Assignees
@MrShevan
Labels
ci Continuous Integration good first issue Good for newcomers
Milestone
future

Comments

@carmocca
Copy link
Member

carmocca commented Jan 4, 2023 •
edited by github-actions bot

Outline & Motivation

docformatter v1.5.1 was released but we are still using v1.4 after we saw issues.

github.com/PyCQA/docformatter: v1.4 → v1.5.1

Pitch

Update this line: https://github.com/Lightning-AI/lightning/blob/3326e65bb2f7de2040bdf300dca062c627cdddb1/.pre-commit-config.yaml#L59

To v1.5.1

Then resolve the failures caused by the update.

Additional context

Already attempted in #16224 and #15344

cc @Borda @carmocca @akihironitta
@carmocca carmocca added good first issue Good for newcomers ci Continuous Integration labels Jan 4, 2023
@carmocca carmocca added this to the future milestone Jan 4, 2023
@carmocca carmocca mentioned this issue Jan 4, 2023
Closed
7 tasks
@MrShevan
Copy link
Contributor

MrShevan commented Jan 5, 2023

Hi! Can I take it?

@MrShevan MrShevan mentioned this issue Jan 5, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MrShevan MrShevan

Labels
ci Continuous Integration good first issue Good for newcomers
Projects
None yet
Milestone
future
Development

Successfully merging a pull request may close this issue.

docformatter update to 1.5 MrShevan/lightning
2 participants
@carmocca @MrShevan