Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docformatter update to 1.5 #16267

Closed
wants to merge 3 commits into from
Closed

docformatter update to 1.5 #16267

wants to merge 3 commits into from

Conversation

MrShevan
Copy link
Contributor

@MrShevan MrShevan commented Jan 5, 2023

What does this PR do?

Fixes #16257

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 馃檭

@MrShevan MrShevan changed the title docformatter update to 1.5.1 docformatter update to 1.5 Jan 5, 2023
Borda
Borda reviewed Jan 6, 2023
View reviewed changes
src/lightning_app/components/multi_node/base.py
@@ -17,7 +17,7 @@ def __init__(
*work_args: Any,
**work_kwargs: Any,
) -> None:
"""This component enables performing distributed multi-node multi-device training.
"""This component enables performing distributed multi-node multi- device training.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think that these kinds of changes are correct...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed. I used pre-commit to run auto-formatting, but looks like something wrong with my environment, since it's not what I had expected. I'll check it.

@stale stale bot added the won't fix This will not be worked on label Mar 18, 2023
@Lightning-AI Lightning-AI deleted a comment from stale bot Mar 18, 2023
@Borda
Copy link
Member

Borda commented Mar 18, 2023

How is it going here?

@stale stale bot removed won't fix This will not be worked on labels Mar 18, 2023
@stale
Copy link

stale bot commented Apr 2, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. If you need further help see our docs: https://lightning.ai/docs/pytorch/latest/generated/CONTRIBUTING.html#pull-request or ask the assistance of a core contributor here or on Discord. Thank you for your contributions.

@stale stale bot added the won't fix This will not be worked on label Apr 2, 2023
@stale
Copy link

stale bot commented Apr 13, 2023

This pull request is going to be closed. Please feel free to reopen it or create a new one based on top of the 'master' branch.

@stale stale bot closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@tchaton tchaton Awaiting requested review from tchaton tchaton will be requested when the pull request is marked ready for review tchaton is a code owner

@lantiga lantiga Awaiting requested review from lantiga lantiga will be requested when the pull request is marked ready for review lantiga is a code owner

@awaelchli awaelchli Awaiting requested review from awaelchli awaelchli will be requested when the pull request is marked ready for review awaelchli is a code owner

@ethanwharris ethanwharris Awaiting requested review from ethanwharris ethanwharris will be requested when the pull request is marked ready for review ethanwharris is a code owner

@carmocca carmocca Awaiting requested review from carmocca carmocca will be requested when the pull request is marked ready for review carmocca is a code owner

@justusschock justusschock Awaiting requested review from justusschock justusschock will be requested when the pull request is marked ready for review justusschock is a code owner

@williamFalcon williamFalcon Awaiting requested review from williamFalcon williamFalcon will be requested when the pull request is marked ready for review williamFalcon is a code owner

Assignees
No one assigned
Labels
won't fix This will not be worked on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the docformatter pre-commit action
2 participants
@MrShevan @Borda