feat: vendor zzlib for unzip #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamboman
force-pushed
the
feat/vendor-zzlib
branch
from
d83c1f4
to
31d5c79
Compare
|
For posterity, the drop-off rate is now ~3%, so this seems like a success (these 3% are most likely all running older plugin version). (data gathered from GitHub release API https://api.mason-registry.dev/api/github/mason-org/mason-registry/releases/latest) |
This was referenced Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Download data of the registry suggest that ~10-18% struggle to unpack the registry archive, with the drop-off occurring in the
unzipstep. Being able to unpack the registry is a very crucial component of mason.nvim, which warrants vendoring zzlib to allow unpacking it entirely in Lua.