Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(windows): manually decompress zstd archives before untar #963

Merged
merged 2 commits into from
Feb 4, 2023
Merged

feat(windows): manually decompress zstd archives before untar #963

merged 2 commits into from
Feb 4, 2023

Conversation

BVegNow
Copy link
Contributor

@BVegNow BVegNow commented Feb 3, 2023

For windows platform it will use zstd first as the windows tar implementation hangs.

Fixes #947.

@williamboman

This comment has been minimized.

Copy link
Owner

@williamboman williamboman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I applied some suggestions (figured it'd be easiest to commit them directly). Wdyt?

@williamboman williamboman changed the title chore: add zstd for win in untar(#622) feat(windows): manually decompress zstd archives before untar Feb 4, 2023
@BVegNow
Copy link
Contributor Author

BVegNow commented Feb 4, 2023

Great! Thanks for reviewing, we can all happily decompress now :)

@BVegNow BVegNow closed this Feb 4, 2023
@williamboman williamboman reopened this Feb 4, 2023
@williamboman williamboman merged commit 9aaadcf into williamboman:main Feb 4, 2023
@BVegNow BVegNow deleted the add-zstd branch February 4, 2023 23:30
williamboman added a commit that referenced this pull request Feb 5, 2023
This accidentally remained in #963.
williamboman added a commit that referenced this pull request Feb 5, 2023
This accidentally remained in #963.
This was referenced Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zls installation fails on Windows
3 participants