Make it possible to pass DOM-object to CanvasSpace instead of id

[jonathanazulay]

In some cases, giving elements an id is undesirable. It would be better to just be able to pass in an object. For example with React, using IDs break the idea of writing reusable components.

Bad

var space = new CanvasSpace('canvas').setup( {bgcolor: '#f1f5f7'} )

render () {
  return (
    <canvas id="canvas" />
  )
}

Good

var space = new CanvasSpace(this.refs.canvas).setup( {bgcolor: '#f1f5f7'} )

render () {
  return (
    <canvas ref="canvas" />
  )
}

[williamngan]

That's a good point. Will fix this to support React and DOM element as parameter.

It uses "id" because it's much easier for beginners to set an "id" in a div then querying the DOM. But definitely should support more advanced uses too.

Thanks @jonathanazulay !

[williamngan]

Fixed :) You should be able to pass a DOM element or an id to initiate a CanvasSpace. Please see if it works.

1a98873

[williamngan]

I've tested it with something like new CanvasSpace(this.refs.canvas).setup( ... ) in React's componentDidMount. It works.

[jonathanazulay]

Sorry for the late feedback! Works great, thanks 💯 👍