Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop is triggered on mouse up even if no drag #61

Closed
tibotiber opened this issue May 13, 2019 · 1 comment · Fixed by #62
Closed

drop is triggered on mouse up even if no drag #61

tibotiber opened this issue May 13, 2019 · 1 comment · Fixed by #62

Comments

@tibotiber
Copy link
Contributor

Hi @williamngan, this is a very amazing lib you've created there. Thanks a bunch :).

It seems that the UIDragger triggers drop events on mouse up even when there has been no dragging. Let me know if this is not clear enough.

I'm gonna push a PR with a suggested fix which I tested for my usage. Hope it can help.
@tibotiber tibotiber mentioned this issue May 13, 2019
Merged
@tibotiber tibotiber changed the title An extra drop is triggered drop is triggered on mouse up even if no drag May 15, 2019
@tibotiber tibotiber mentioned this issue May 15, 2019
Closed
@williamngan
Copy link
Owner

Hi @tibotiber , thank you so much for catching this and submitting a PR too. The PR looks good. Thank you 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/extra drop tibotiber/pts
2 participants
@williamngan @tibotiber