Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with main project when used as library project #2

Closed
GoogleCodeExporter opened this issue Apr 8, 2016 · 4 comments
Closed

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Create a project with Android Support v7 AppCompat
2. Use barcodefraglibv2 as library project

What is the expected output? What do you see instead?
It should be OK, but in reality caught IllegalStateException because 
AppCompat's activities needs Theme.AppCompat as the theme.

What version of the product are you using?
Commit b5b9b2a4dfa9d9b82651eaf4f3c8c67a80e8d2bf (Thu Nov 21 08:29:33 2013 
+0000).

Please provide any additional information below.
I tried to remove unnecessary resources (and also examples), and it solved. I 
suggest to shrink the project so it uses only the necessary resources and 
separate the core library with example project.

Thanks

Original issue reported on code.google.com by fik...@gmail.com on 10 Dec 2013 at 7:17

@GoogleCodeExporter
Copy link
Author

Will look into this. thanks for feedback

Original comment by abhinava...@gmail.com on 14 Dec 2013 at 11:29

  • Changed state: Accepted
  • Added labels: Priority-Low
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author

Barcode library needs support v4 for backword compatibility.
Can you please provide the dependencies that were removed by you in order to 
fix the issue.

Original comment by abhinava...@gmail.com on 16 Apr 2014 at 4:29

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

I have forgotten, fortunately git still saves the history. This is the summary:

M   .classpath
A   .gitignore
M   AndroidManifest.xml
D   gen/com/abhi/barcode/frag/libv2/BuildConfig.java
D   gen/com/abhi/barcode/frag/libv2/R.java
D   res/drawable-hdpi/ic_launcher.png
D   res/drawable-mdpi/ic_launcher.png
D   res/drawable-xhdpi/ic_launcher.png
D   res/drawable-xxhdpi/ic_launcher.png
D   res/layout/activity_barcode_fragment_example.xml
D   res/menu/barcode_fragment_example.xml
D   res/values-sw600dp/dimens.xml
D   res/values-sw720dp-land/dimens.xml
D   res/values-v11/styles.xml
D   res/values-v14/styles.xml
D   res/values/dimens.xml
M   res/values/strings.xml
D   res/values/styles.xml
D   src/com/abhi/barcode/frag/libv2/sample/activity/BarcodeFragmentExampleActivity
.java
M   src/com/google/zxing/client/android/camera/CameraManager.java

It seems that what I've done are:
- Change min SDK to level 8
- Remove examples files (classes and related resources)
- Remove generated files from version control

Original comment by fik...@gmail.com on 16 Apr 2014 at 4:59

Attachments:

@GoogleCodeExporter
Copy link
Author

It seems the issue was due to usage of V4 and not V7 in sample.
We have added the sample with V4 as its commonly used and have added as a 
sample so that library can be easily tested for usage before working on it.

Although it will be great to remove dependencies but i preffer to leave it as 
it is.

Thanks again for reporting the issue. I will add a note under usage guideline.

Original comment by abhinava...@gmail.com on 16 Apr 2014 at 6:44

  • Changed state: WontFix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant